From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net-next] netlink: gc useless variable in nlmsg_attrdata()
Date: Fri, 13 Aug 2021 10:23:33 +0800 [thread overview]
Message-ID: <202108131042.tn73Br92-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2633 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <YRWRcbWR45+zF9mD@localhost.localdomain>
References: <YRWRcbWR45+zF9mD@localhost.localdomain>
TO: Alexey Dobriyan <adobriyan@gmail.com>
TO: davem(a)davemloft.net
CC: netdev(a)vger.kernel.org
Hi Alexey,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Alexey-Dobriyan/netlink-gc-useless-variable-in-nlmsg_attrdata/20210813-052557
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bed5a942e27e1df67250e27e1f2eb5ea2d4cc362
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-m021-20210812 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ipv4/inet_diag.c:219 inet_diag_parse_attrs() warn: potential spectre issue 'req_nlas' [w] (local cap)
Old smatch warnings:
include/linux/cgroup-defs.h:817 sock_cgroup_classid() warn: maybe use && instead of &
vim +/req_nlas +219 net/ipv4/inet_diag.c
cb2050a7b8131a9 Xin Long 2016-04-14 205
d5e4d0a5e692a94 Eric Dumazet 2020-09-21 206 static int inet_diag_parse_attrs(const struct nlmsghdr *nlh, int hdrlen,
3f935c75eb52dd9 Paolo Abeni 2020-07-09 207 struct nlattr **req_nlas)
3f935c75eb52dd9 Paolo Abeni 2020-07-09 208 {
3f935c75eb52dd9 Paolo Abeni 2020-07-09 209 struct nlattr *nla;
3f935c75eb52dd9 Paolo Abeni 2020-07-09 210 int remaining;
3f935c75eb52dd9 Paolo Abeni 2020-07-09 211
3f935c75eb52dd9 Paolo Abeni 2020-07-09 212 nlmsg_for_each_attr(nla, nlh, hdrlen, remaining) {
3f935c75eb52dd9 Paolo Abeni 2020-07-09 213 int type = nla_type(nla);
3f935c75eb52dd9 Paolo Abeni 2020-07-09 214
d5e4d0a5e692a94 Eric Dumazet 2020-09-21 215 if (type == INET_DIAG_REQ_PROTOCOL && nla_len(nla) != sizeof(u32))
d5e4d0a5e692a94 Eric Dumazet 2020-09-21 216 return -EINVAL;
d5e4d0a5e692a94 Eric Dumazet 2020-09-21 217
3f935c75eb52dd9 Paolo Abeni 2020-07-09 218 if (type < __INET_DIAG_REQ_MAX)
3f935c75eb52dd9 Paolo Abeni 2020-07-09 @219 req_nlas[type] = nla;
3f935c75eb52dd9 Paolo Abeni 2020-07-09 220 }
d5e4d0a5e692a94 Eric Dumazet 2020-09-21 221 return 0;
3f935c75eb52dd9 Paolo Abeni 2020-07-09 222 }
3f935c75eb52dd9 Paolo Abeni 2020-07-09 223
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35148 bytes --]
next reply other threads:[~2021-08-13 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 2:23 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-12 21:24 [PATCH net-next] netlink: gc useless variable in nlmsg_attrdata() Alexey Dobriyan
2021-08-12 22:05 ` Jakub Kicinski
2021-08-13 5:27 ` Alexey Dobriyan
2021-08-13 17:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108131042.tn73Br92-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.