From: Alexey Dobriyan <adobriyan@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] netlink: gc useless variable in nlmsg_attrdata()
Date: Fri, 13 Aug 2021 00:24:01 +0300 [thread overview]
Message-ID: <YRWRcbWR45+zF9mD@localhost.localdomain> (raw)
Kernel permits pointer arithmetic on "void*" so might as well use it
without casts back and forth.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/net/netlink.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -587,8 +587,7 @@ static inline int nlmsg_len(const struct nlmsghdr *nlh)
static inline struct nlattr *nlmsg_attrdata(const struct nlmsghdr *nlh,
int hdrlen)
{
- unsigned char *data = nlmsg_data(nlh);
- return (struct nlattr *) (data + NLMSG_ALIGN(hdrlen));
+ return nlmsg_data(nlh) + NLMSG_ALIGN(hdrlen);
}
/**
next reply other threads:[~2021-08-12 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 21:24 Alexey Dobriyan [this message]
2021-08-12 22:05 ` [PATCH net-next] netlink: gc useless variable in nlmsg_attrdata() Jakub Kicinski
2021-08-13 5:27 ` Alexey Dobriyan
2021-08-13 17:29 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2021-08-13 2:23 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRWRcbWR45+zF9mD@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.