All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	kbuild-all@lists.01.org,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v1 2/4] powerpc/64s/perf: add power_pmu_running to query whether perf is being used
Date: Tue, 17 Aug 2021 02:19:37 +0800	[thread overview]
Message-ID: <202108170232.bpDelLsl-lkp@intel.com> (raw)
In-Reply-To: <20210816072953.1165964-3-npiggin@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.14-rc6 next-20210816]
[cannot apply to scottwood/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210816-153424
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-wii_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/98b8a35aa718c93ace9df66df6274fe392633f80
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210816-153424
        git checkout 98b8a35aa718c93ace9df66df6274fe392633f80
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/powerpc/perf/core-book3s.c:2392:6: error: no previous prototype for 'power_pmu_running' [-Werror=missing-prototypes]
    2392 | bool power_pmu_running(void)
         |      ^~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/power_pmu_running +2392 arch/powerpc/perf/core-book3s.c

  2391	
> 2392	bool power_pmu_running(void)
  2393	{
  2394		struct cpu_hw_events *cpuhw;
  2395	
  2396		/* Could this simply test local_paca->pmcregs_in_use? */
  2397	
  2398		if (!ppmu)
  2399			return false;
  2400	
  2401		cpuhw = this_cpu_ptr(&cpu_hw_events);
  2402		return cpuhw->n_events;
  2403	}
  2404	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16544 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 2/4] powerpc/64s/perf: add power_pmu_running to query whether perf is being used
Date: Tue, 17 Aug 2021 02:19:37 +0800	[thread overview]
Message-ID: <202108170232.bpDelLsl-lkp@intel.com> (raw)
In-Reply-To: <20210816072953.1165964-3-npiggin@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.14-rc6 next-20210816]
[cannot apply to scottwood/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210816-153424
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-wii_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/98b8a35aa718c93ace9df66df6274fe392633f80
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210816-153424
        git checkout 98b8a35aa718c93ace9df66df6274fe392633f80
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/powerpc/perf/core-book3s.c:2392:6: error: no previous prototype for 'power_pmu_running' [-Werror=missing-prototypes]
    2392 | bool power_pmu_running(void)
         |      ^~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/power_pmu_running +2392 arch/powerpc/perf/core-book3s.c

  2391	
> 2392	bool power_pmu_running(void)
  2393	{
  2394		struct cpu_hw_events *cpuhw;
  2395	
  2396		/* Could this simply test local_paca->pmcregs_in_use? */
  2397	
  2398		if (!ppmu)
  2399			return false;
  2400	
  2401		cpuhw = this_cpu_ptr(&cpu_hw_events);
  2402		return cpuhw->n_events;
  2403	}
  2404	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 16544 bytes --]

  reply	other threads:[~2021-08-16 18:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  7:29 [PATCH v1 0/4] powerpc/64s: interrupt speedups Nicholas Piggin
2021-08-16  7:29 ` [PATCH v1 1/4] powerpc/64: handle MSR EE and RI in interrupt entry wrapper Nicholas Piggin
2021-08-16  7:29 ` [PATCH v1 2/4] powerpc/64s/perf: add power_pmu_running to query whether perf is being used Nicholas Piggin
2021-08-16 18:19   ` kernel test robot [this message]
2021-08-16 18:19     ` kernel test robot
2021-08-17 13:06   ` Madhavan Srinivasan
2021-08-18 11:41     ` Nicholas Piggin
2021-08-18 12:14       ` Athira Rajeev
2021-08-17 13:42   ` Michael Ellerman
2021-08-16  7:29 ` [PATCH v1 3/4] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use Nicholas Piggin
2021-08-16  7:29 ` [PATCH v1 4/4] powerpc/64s/interrupt: avoid saving CFAR in some asynchronous interrupts Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108170232.bpDelLsl-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.