All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Matt Corallo <oc2udbzfd@mattcorallo.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Emiliano Ingrassia <ingrassia@epigenesys.com>,
	Brian Kim <brian.kim@hardkernel.com>
Subject: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power
Date: Tue, 17 Aug 2021 09:45:37 +0530	[thread overview]
Message-ID: <20210817041548.1276-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com>

Fix the chip enable signal changing from Active High to Active Low
to enable input power to USB power. Also updated signal name as per
the schematics.

Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes")

Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2:
Fix the typo: shematics -> schematics
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3f4f16a5dedd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs {
 		regulator-max-microvolt = <5000000>;
 
 		/*
-		 * signal name from schematics: PWREN
+		 * signal name from schematics: PWREN - GPIOAO.BIT5
 		 */
-		gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>;
 		/*
-		 * signal name from schematics: USB_POWER
+		 * signal name from schematics: USB_POWER - P5V0
 		 */
 		vin-supply = <&p5v0>;
 	};
-- 
2.32.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Matt Corallo <oc2udbzfd@mattcorallo.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Emiliano Ingrassia <ingrassia@epigenesys.com>,
	Brian Kim <brian.kim@hardkernel.com>
Subject: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power
Date: Tue, 17 Aug 2021 09:45:37 +0530	[thread overview]
Message-ID: <20210817041548.1276-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com>

Fix the chip enable signal changing from Active High to Active Low
to enable input power to USB power. Also updated signal name as per
the schematics.

Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes")

Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2:
Fix the typo: shematics -> schematics
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3f4f16a5dedd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs {
 		regulator-max-microvolt = <5000000>;
 
 		/*
-		 * signal name from schematics: PWREN
+		 * signal name from schematics: PWREN - GPIOAO.BIT5
 		 */
-		gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>;
 		/*
-		 * signal name from schematics: USB_POWER
+		 * signal name from schematics: USB_POWER - P5V0
 		 */
 		vin-supply = <&p5v0>;
 	};
-- 
2.32.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Matt Corallo <oc2udbzfd@mattcorallo.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Emiliano Ingrassia <ingrassia@epigenesys.com>,
	Brian Kim <brian.kim@hardkernel.com>
Subject: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power
Date: Tue, 17 Aug 2021 09:45:37 +0530	[thread overview]
Message-ID: <20210817041548.1276-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com>

Fix the chip enable signal changing from Active High to Active Low
to enable input power to USB power. Also updated signal name as per
the schematics.

Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes")

Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2:
Fix the typo: shematics -> schematics
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3f4f16a5dedd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs {
 		regulator-max-microvolt = <5000000>;
 
 		/*
-		 * signal name from schematics: PWREN
+		 * signal name from schematics: PWREN - GPIOAO.BIT5
 		 */
-		gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>;
 		/*
-		 * signal name from schematics: USB_POWER
+		 * signal name from schematics: USB_POWER - P5V0
 		 */
 		vin-supply = <&p5v0>;
 	};
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Matt Corallo <oc2udbzfd@mattcorallo.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Emiliano Ingrassia <ingrassia@epigenesys.com>,
	Brian Kim <brian.kim@hardkernel.com>
Subject: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power
Date: Tue, 17 Aug 2021 09:45:37 +0530	[thread overview]
Message-ID: <20210817041548.1276-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com>

Fix the chip enable signal changing from Active High to Active Low
to enable input power to USB power. Also updated signal name as per
the schematics.

Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes")

Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2:
Fix the typo: shematics -> schematics
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3f4f16a5dedd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs {
 		regulator-max-microvolt = <5000000>;
 
 		/*
-		 * signal name from schematics: PWREN
+		 * signal name from schematics: PWREN - GPIOAO.BIT5
 		 */
-		gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>;
 		/*
-		 * signal name from schematics: USB_POWER
+		 * signal name from schematics: USB_POWER - P5V0
 		 */
 		vin-supply = <&p5v0>;
 	};
-- 
2.32.0


  parent reply	other threads:[~2021-08-17  4:18 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  4:15 [PATCHv3 0/6] Meson-8b and Meson-gxbb Fix some missing code Anand Moon
2021-08-17  4:15 ` Anand Moon
2021-08-17  4:15 ` Anand Moon
2021-08-17  4:15 ` Anand Moon
2021-08-17  4:15 ` [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-28 15:53   ` Martin Blumenstingl
2021-08-28 15:53     ` Martin Blumenstingl
2021-08-28 15:53     ` Martin Blumenstingl
2021-08-28 15:53     ` Martin Blumenstingl
2021-08-30  7:45   ` Neil Armstrong
2021-08-30  7:45     ` Neil Armstrong
2021-08-30  7:45     ` Neil Armstrong
2021-08-30  7:45     ` Neil Armstrong
2021-08-30 19:37     ` Martin Blumenstingl
2021-08-30 19:37       ` Martin Blumenstingl
2021-08-30 19:37       ` Martin Blumenstingl
2021-08-30 19:37       ` Martin Blumenstingl
2021-08-31 14:50       ` Neil Armstrong
2021-08-31 14:50         ` Neil Armstrong
2021-08-31 14:50         ` Neil Armstrong
2021-08-31 14:50         ` Neil Armstrong
2021-08-31 20:47         ` Anand Moon
2021-08-31 20:47           ` Anand Moon
2021-08-31 20:47           ` Anand Moon
2021-08-31 20:47           ` Anand Moon
2021-09-20 19:26           ` Martin Blumenstingl
2021-09-20 19:26             ` Martin Blumenstingl
2021-09-20 19:26             ` Martin Blumenstingl
2021-09-20 19:26             ` Martin Blumenstingl
2021-09-25 17:41             ` Anand Moon
2021-09-25 17:41               ` Anand Moon
2021-09-25 17:41               ` Anand Moon
2021-09-25 17:41               ` Anand Moon
2021-08-17  4:15 ` [PATCHv3 2/6] ARM: dts: meson8b: odroidc1: Set usb power source to always on Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-28 15:56   ` Martin Blumenstingl
2021-08-28 15:56     ` Martin Blumenstingl
2021-08-28 15:56     ` Martin Blumenstingl
2021-08-28 15:56     ` Martin Blumenstingl
2021-08-17  4:15 ` Anand Moon [this message]
2021-08-17  4:15   ` [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-28 16:00   ` Martin Blumenstingl
2021-08-28 16:00     ` Martin Blumenstingl
2021-08-28 16:00     ` Martin Blumenstingl
2021-08-28 16:00     ` Martin Blumenstingl
2021-08-17  4:15 ` [PATCHv3 4/6] arm64: dts: amlogic: odroidc2: use vbus-supply for power source for usb nodes Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-28 16:06   ` Martin Blumenstingl
2021-08-28 16:06     ` Martin Blumenstingl
2021-08-28 16:06     ` Martin Blumenstingl
2021-08-28 16:06     ` Martin Blumenstingl
2021-08-17  4:15 ` [PATCHv3 5/6] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17 10:30   ` Vinod Koul
2021-08-17 10:30     ` Vinod Koul
2021-08-17 10:30     ` Vinod Koul
2021-08-17 10:30     ` Vinod Koul
2021-08-17  4:15 ` [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17  4:15   ` Anand Moon
2021-08-17 10:31   ` Vinod Koul
2021-08-17 10:31     ` Vinod Koul
2021-08-17 10:31     ` Vinod Koul
2021-08-17 10:31     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817041548.1276-4-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=brian.kim@hardkernel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ingrassia@epigenesys.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=kishon@ti.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=oc2udbzfd@mattcorallo.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.