All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [ti:ti-rt-linux-5.10.y 6817/6833] drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used
Date: Wed, 18 Aug 2021 01:39:08 +0800	[thread overview]
Message-ID: <202108180100.br89B0SX-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head:   ac3657d2050406e974383b1490184f42a06b73cc
commit: b5eff5a26c1aa3a3872533555a4678d510d07f87 [6817/6833] drm/omap: add WB support
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
        git fetch --no-tags ti ti-rt-linux-5.10.y
        git checkout b5eff5a26c1aa3a3872533555a4678d510d07f87
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/omapdrm/omap_wb_cap.c: In function 'stop_streaming':
>> drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     512 |         int ret;
         |             ^~~


vim +/ret +512 drivers/gpu/drm/omapdrm/omap_wb_cap.c

   502	
   503	/*
   504	 * Stop the DMA engine. Any remaining buffers in the DMA queue are dequeued
   505	 * and passed on to the vb2 framework marked as STATE_ERROR.
   506	 */
   507	static void stop_streaming(struct vb2_queue *vq)
   508	{
   509		struct wbcap_dev *wbcap = vb2_get_drv_priv(vq);
   510		struct omap_drm_private *priv = wbcap->dev->drm_dev->dev_private;
   511		struct drm_crtc *crtc;
 > 512		int ret;
   513	
   514		log_dbg(wbcap, "Stopping WB\n");
   515		log_dbg(wbcap, "current state: %d\n", wbcap->state);
   516	
   517		wbcap->stopping = true;
   518		ret = wait_event_timeout(wbcap->event,
   519					 !wbcap->stopping,
   520					 msecs_to_jiffies(250));
   521	
   522		log_dbg(wbcap, "Returning VB2 buffers\n");
   523	
   524		if (priv->dispc_ops->wb_go_busy(priv->dispc))
   525			log_err(wbcap, "WARNING, WB BUSY when stopping\n");
   526	
   527		/* Release all active buffers */
   528		return_all_buffers(wbcap, VB2_BUF_STATE_ERROR);
   529	
   530		/* Disable vsync irq on the input crtc */
   531		crtc = priv->pipes[wb_inputs[wbcap->input].crtc_index].crtc;
   532		drm_crtc_vblank_put(crtc);
   533	
   534		priv->dispc_ops->runtime_put(priv->dispc);
   535	}
   536	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 77057 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Benoit Parrot <bparrot@ti.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [ti:ti-rt-linux-5.10.y 6817/6833] drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used
Date: Wed, 18 Aug 2021 01:39:08 +0800	[thread overview]
Message-ID: <202108180100.br89B0SX-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2587 bytes --]

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head:   ac3657d2050406e974383b1490184f42a06b73cc
commit: b5eff5a26c1aa3a3872533555a4678d510d07f87 [6817/6833] drm/omap: add WB support
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
        git fetch --no-tags ti ti-rt-linux-5.10.y
        git checkout b5eff5a26c1aa3a3872533555a4678d510d07f87
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/omapdrm/omap_wb_cap.c: In function 'stop_streaming':
>> drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     512 |         int ret;
         |             ^~~


vim +/ret +512 drivers/gpu/drm/omapdrm/omap_wb_cap.c

   502	
   503	/*
   504	 * Stop the DMA engine. Any remaining buffers in the DMA queue are dequeued
   505	 * and passed on to the vb2 framework marked as STATE_ERROR.
   506	 */
   507	static void stop_streaming(struct vb2_queue *vq)
   508	{
   509		struct wbcap_dev *wbcap = vb2_get_drv_priv(vq);
   510		struct omap_drm_private *priv = wbcap->dev->drm_dev->dev_private;
   511		struct drm_crtc *crtc;
 > 512		int ret;
   513	
   514		log_dbg(wbcap, "Stopping WB\n");
   515		log_dbg(wbcap, "current state: %d\n", wbcap->state);
   516	
   517		wbcap->stopping = true;
   518		ret = wait_event_timeout(wbcap->event,
   519					 !wbcap->stopping,
   520					 msecs_to_jiffies(250));
   521	
   522		log_dbg(wbcap, "Returning VB2 buffers\n");
   523	
   524		if (priv->dispc_ops->wb_go_busy(priv->dispc))
   525			log_err(wbcap, "WARNING, WB BUSY when stopping\n");
   526	
   527		/* Release all active buffers */
   528		return_all_buffers(wbcap, VB2_BUF_STATE_ERROR);
   529	
   530		/* Disable vsync irq on the input crtc */
   531		crtc = priv->pipes[wb_inputs[wbcap->input].crtc_index].crtc;
   532		drm_crtc_vblank_put(crtc);
   533	
   534		priv->dispc_ops->runtime_put(priv->dispc);
   535	}
   536	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77057 bytes --]

             reply	other threads:[~2021-08-17 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 17:39 kernel test robot [this message]
2021-08-17 17:39 ` [ti:ti-rt-linux-5.10.y 6817/6833] drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108180100.br89B0SX-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.