From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PCI <linux-pci@vger.kernel.org>,
Jonathan Derrick <jonathan.derrick@intel.com>
Cc: kbuild-all@lists.01.org, Wendy Wang <wendy.wang@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
David Box <david.e.box@linux.intel.com>
Subject: [RFC PATCH] PCI: VMD: ACPI: pci_acpi_companion_lookup_key can be static
Date: Sat, 21 Aug 2021 05:06:10 +0800 [thread overview]
Message-ID: <20210820210610.GA23698@ef1ee8e5bb1c> (raw)
In-Reply-To: <11834551.O9o76ZdvQC@kreacher>
drivers/pci/pci-acpi.c:1164:1: warning: symbol 'pci_acpi_companion_lookup_key' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
pci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 535f43034a073..c8718aeafae5d 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -1161,7 +1161,7 @@ void acpi_pci_remove_bus(struct pci_bus *bus)
/* ACPI bus type */
-DEFINE_STATIC_KEY_FALSE(pci_acpi_companion_lookup_key);
+static DEFINE_STATIC_KEY_FALSE(pci_acpi_companion_lookup_key);
static DEFINE_MUTEX(pci_acpi_companion_lookup_mtx);
static struct acpi_device *(*pci_acpi_find_companion_hook)(struct pci_dev *);
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] PCI: VMD: ACPI: pci_acpi_companion_lookup_key can be static
Date: Sat, 21 Aug 2021 05:06:10 +0800 [thread overview]
Message-ID: <20210820210610.GA23698@ef1ee8e5bb1c> (raw)
In-Reply-To: <11834551.O9o76ZdvQC@kreacher>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
drivers/pci/pci-acpi.c:1164:1: warning: symbol 'pci_acpi_companion_lookup_key' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
pci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 535f43034a073..c8718aeafae5d 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -1161,7 +1161,7 @@ void acpi_pci_remove_bus(struct pci_bus *bus)
/* ACPI bus type */
-DEFINE_STATIC_KEY_FALSE(pci_acpi_companion_lookup_key);
+static DEFINE_STATIC_KEY_FALSE(pci_acpi_companion_lookup_key);
static DEFINE_MUTEX(pci_acpi_companion_lookup_mtx);
static struct acpi_device *(*pci_acpi_find_companion_hook)(struct pci_dev *);
next prev parent reply other threads:[~2021-08-20 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 16:12 [PATCH] PCI: VMD: ACPI: Make ACPI companion lookup work for VMD bus Rafael J. Wysocki
2021-08-20 17:12 ` Bjorn Helgaas
2021-08-20 18:15 ` Rafael J. Wysocki
2021-08-20 17:15 ` Jon Derrick
2021-08-20 18:23 ` Rafael J. Wysocki
2021-08-20 21:06 ` kernel test robot
2021-08-20 21:06 ` kernel test robot
2021-08-20 21:06 ` kernel test robot [this message]
2021-08-20 21:06 ` [RFC PATCH] PCI: VMD: ACPI: pci_acpi_companion_lookup_key can be static kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820210610.GA23698@ef1ee8e5bb1c \
--to=lkp@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=wendy.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.