All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, martin@kaiser.cx,
	straube.linux@gmail.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent
Date: Sat, 21 Aug 2021 11:10:35 +0800	[thread overview]
Message-ID: <202108211104.R2np9jK2-lkp@intel.com> (raw)
In-Reply-To: <20210821000508.79422-1-phil@philpotter.co.uk>

[-- Attachment #1: Type: text/plain, Size: 3411 bytes --]

Hi Phillip,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
        git checkout 195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/r8188eu/core/rtw_efuse.c:33:1: warning: no previous prototype for 'Efuse_Read1ByteFromFakeContent' [-Wmissing-prototypes]
      33 | Efuse_Read1ByteFromFakeContent(
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/Efuse_Read1ByteFromFakeContent +33 drivers/staging/r8188eu/core/rtw_efuse.c

15865124feed88 Phillip Potter 2021-07-28  27  
15865124feed88 Phillip Potter 2021-07-28  28  /*  */
15865124feed88 Phillip Potter 2021-07-28  29  #define REG_EFUSE_CTRL		0x0030
15865124feed88 Phillip Potter 2021-07-28  30  #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
15865124feed88 Phillip Potter 2021-07-28  31  /*  */
15865124feed88 Phillip Potter 2021-07-28  32  bool
15865124feed88 Phillip Potter 2021-07-28 @33  Efuse_Read1ByteFromFakeContent(
15865124feed88 Phillip Potter 2021-07-28  34  			struct adapter *pAdapter,
15865124feed88 Phillip Potter 2021-07-28  35  			u16 Offset,
15865124feed88 Phillip Potter 2021-07-28  36  		u8 *Value)
15865124feed88 Phillip Potter 2021-07-28  37  {
15865124feed88 Phillip Potter 2021-07-28  38  	if (Offset >= EFUSE_MAX_HW_SIZE)
15865124feed88 Phillip Potter 2021-07-28  39  		return false;
15865124feed88 Phillip Potter 2021-07-28  40  	if (fakeEfuseBank == 0)
15865124feed88 Phillip Potter 2021-07-28  41  		*Value = fakeEfuseContent[Offset];
15865124feed88 Phillip Potter 2021-07-28  42  	else
15865124feed88 Phillip Potter 2021-07-28  43  		*Value = fakeBTEfuseContent[fakeEfuseBank - 1][Offset];
15865124feed88 Phillip Potter 2021-07-28  44  	return true;
15865124feed88 Phillip Potter 2021-07-28  45  }
15865124feed88 Phillip Potter 2021-07-28  46  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55027 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent
Date: Sat, 21 Aug 2021 11:10:35 +0800	[thread overview]
Message-ID: <202108211104.R2np9jK2-lkp@intel.com> (raw)
In-Reply-To: <20210821000508.79422-1-phil@philpotter.co.uk>

[-- Attachment #1: Type: text/plain, Size: 3476 bytes --]

Hi Phillip,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
        git checkout 195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/r8188eu/core/rtw_efuse.c:33:1: warning: no previous prototype for 'Efuse_Read1ByteFromFakeContent' [-Wmissing-prototypes]
      33 | Efuse_Read1ByteFromFakeContent(
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/Efuse_Read1ByteFromFakeContent +33 drivers/staging/r8188eu/core/rtw_efuse.c

15865124feed88 Phillip Potter 2021-07-28  27  
15865124feed88 Phillip Potter 2021-07-28  28  /*  */
15865124feed88 Phillip Potter 2021-07-28  29  #define REG_EFUSE_CTRL		0x0030
15865124feed88 Phillip Potter 2021-07-28  30  #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
15865124feed88 Phillip Potter 2021-07-28  31  /*  */
15865124feed88 Phillip Potter 2021-07-28  32  bool
15865124feed88 Phillip Potter 2021-07-28 @33  Efuse_Read1ByteFromFakeContent(
15865124feed88 Phillip Potter 2021-07-28  34  			struct adapter *pAdapter,
15865124feed88 Phillip Potter 2021-07-28  35  			u16 Offset,
15865124feed88 Phillip Potter 2021-07-28  36  		u8 *Value)
15865124feed88 Phillip Potter 2021-07-28  37  {
15865124feed88 Phillip Potter 2021-07-28  38  	if (Offset >= EFUSE_MAX_HW_SIZE)
15865124feed88 Phillip Potter 2021-07-28  39  		return false;
15865124feed88 Phillip Potter 2021-07-28  40  	if (fakeEfuseBank == 0)
15865124feed88 Phillip Potter 2021-07-28  41  		*Value = fakeEfuseContent[Offset];
15865124feed88 Phillip Potter 2021-07-28  42  	else
15865124feed88 Phillip Potter 2021-07-28  43  		*Value = fakeBTEfuseContent[fakeEfuseBank - 1][Offset];
15865124feed88 Phillip Potter 2021-07-28  44  	return true;
15865124feed88 Phillip Potter 2021-07-28  45  }
15865124feed88 Phillip Potter 2021-07-28  46  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 55027 bytes --]

  reply	other threads:[~2021-08-21  3:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21  0:05 [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent Phillip Potter
2021-08-21  3:10 ` kernel test robot [this message]
2021-08-21  3:10   ` kernel test robot
2021-08-21  3:17 ` Fabio M. De Francesco
2021-08-21  8:30   ` Michael Straube
2021-08-21 10:42     ` Phillip Potter
2021-08-21 14:45 ` Larry Finger
2021-08-21 17:10   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108211104.R2np9jK2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.