Re: [for-rc] RDMA/qedr: qedr crash while running rdma-tool.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4811 bytes --]

Hi Alok,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on v5.14-rc6 next-20210820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alok-Prasad/RDMA-qedr-qedr-crash-while-running-rdma-tool/20210821-154459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f9b6462f18a87caead9b362d4cdd049504ac3c62
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alok-Prasad/RDMA-qedr-qedr-crash-while-running-rdma-tool/20210821-154459
        git checkout f9b6462f18a87caead9b362d4cdd049504ac3c62
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_query_qp':
>> drivers/infiniband/hw/qedr/verbs.c:2754:35: warning: implicit conversion from 'enum qed_roce_qp_state' to 'enum ib_qp_state' [-Wenum-conversion]
    2754 |                 qp_attr->qp_state = QED_ROCE_QP_STATE_RTS;
         |                                   ^


vim +2754 drivers/infiniband/hw/qedr/verbs.c

  2735	
  2736	int qedr_query_qp(struct ib_qp *ibqp,
  2737			  struct ib_qp_attr *qp_attr,
  2738			  int attr_mask, struct ib_qp_init_attr *qp_init_attr)
  2739	{
  2740		struct qed_rdma_query_qp_out_params params;
  2741		struct qedr_qp *qp = get_qedr_qp(ibqp);
  2742		struct qedr_dev *dev = qp->dev;
  2743		int rc = 0;
  2744	
  2745		memset(&params, 0, sizeof(params));
  2746		memset(qp_attr, 0, sizeof(*qp_attr));
  2747		memset(qp_init_attr, 0, sizeof(*qp_init_attr));
  2748	
  2749		if (qp->qed_qp)
  2750			rc = dev->ops->rdma_query_qp(dev->rdma_ctx,
  2751						     qp->qed_qp, &params);
  2752	
  2753		if (qp->qp_type == IB_QPT_GSI)
> 2754			qp_attr->qp_state = QED_ROCE_QP_STATE_RTS;
  2755		else
  2756			qp_attr->qp_state = qedr_get_ibqp_state(params.state);
  2757	
  2758		qp_attr->cur_qp_state = qedr_get_ibqp_state(params.state);
  2759		qp_attr->path_mtu = ib_mtu_int_to_enum(params.mtu);
  2760		qp_attr->path_mig_state = IB_MIG_MIGRATED;
  2761		qp_attr->rq_psn = params.rq_psn;
  2762		qp_attr->sq_psn = params.sq_psn;
  2763		qp_attr->dest_qp_num = params.dest_qp;
  2764	
  2765		qp_attr->qp_access_flags = qedr_to_ib_qp_acc_flags(&params);
  2766	
  2767		qp_attr->cap.max_send_wr = qp->sq.max_wr;
  2768		qp_attr->cap.max_recv_wr = qp->rq.max_wr;
  2769		qp_attr->cap.max_send_sge = qp->sq.max_sges;
  2770		qp_attr->cap.max_recv_sge = qp->rq.max_sges;
  2771		qp_attr->cap.max_inline_data = dev->attr.max_inline;
  2772		qp_init_attr->cap = qp_attr->cap;
  2773	
  2774		qp_attr->ah_attr.type = RDMA_AH_ATTR_TYPE_ROCE;
  2775		rdma_ah_set_grh(&qp_attr->ah_attr, NULL,
  2776				params.flow_label, qp->sgid_idx,
  2777				params.hop_limit_ttl, params.traffic_class_tos);
  2778		rdma_ah_set_dgid_raw(&qp_attr->ah_attr, &params.dgid.bytes[0]);
  2779		rdma_ah_set_port_num(&qp_attr->ah_attr, 1);
  2780		rdma_ah_set_sl(&qp_attr->ah_attr, 0);
  2781		qp_attr->timeout = params.timeout;
  2782		qp_attr->rnr_retry = params.rnr_retry;
  2783		qp_attr->retry_cnt = params.retry_cnt;
  2784		qp_attr->min_rnr_timer = params.min_rnr_nak_timer;
  2785		qp_attr->pkey_index = params.pkey_index;
  2786		qp_attr->port_num = 1;
  2787		rdma_ah_set_path_bits(&qp_attr->ah_attr, 0);
  2788		rdma_ah_set_static_rate(&qp_attr->ah_attr, 0);
  2789		qp_attr->alt_pkey_index = 0;
  2790		qp_attr->alt_port_num = 0;
  2791		qp_attr->alt_timeout = 0;
  2792		memset(&qp_attr->alt_ah_attr, 0, sizeof(qp_attr->alt_ah_attr));
  2793	
  2794		qp_attr->sq_draining = (params.state == QED_ROCE_QP_STATE_SQD) ? 1 : 0;
  2795		qp_attr->max_dest_rd_atomic = params.max_dest_rd_atomic;
  2796		qp_attr->max_rd_atomic = params.max_rd_atomic;
  2797		qp_attr->en_sqd_async_notify = (params.sqd_async) ? 1 : 0;
  2798	
  2799		DP_DEBUG(dev, QEDR_MSG_QP, "QEDR_QUERY_QP: max_inline_data=%d\n",
  2800			 qp_attr->cap.max_inline_data);
  2801		return rc;
  2802	}
  2803	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73335 bytes --]