[bug report] net/mlx5: Bridge, allow merged eswitch connectivity

[bug report] net/mlx5: Bridge, allow merged eswitch connectivity

[Dan Carpenter]

Hello Vlad Buslov,

The patch c358ea1741bc: "net/mlx5: Bridge, allow merged eswitch
connectivity" from Jun 25, 2021, leads to the following
Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:164 mlx5_esw_bridge_port_changeupper()
	error: uninitialized symbol 'err'.

drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c
    128 static int mlx5_esw_bridge_port_changeupper(struct notifier_block *nb, void *ptr)
    129 {
    130 	struct mlx5_esw_bridge_offloads *br_offloads = container_of(nb,
    131 								    struct mlx5_esw_bridge_offloads,
    132 								    netdev_nb);
    133 	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
    134 	struct netdev_notifier_changeupper_info *info = ptr;
    135 	struct net_device *upper = info->upper_dev, *rep;
    136 	struct mlx5_eswitch *esw = br_offloads->esw;
    137 	u16 vport_num, esw_owner_vhca_id;
    138 	struct netlink_ext_ack *extack;
    139 	int ifindex = upper->ifindex;
    140 	int err;
    141 
    142 	if (!netif_is_bridge_master(upper))
    143 		return 0;
    144 
    145 	rep = mlx5_esw_bridge_rep_vport_num_vhca_id_get(dev, esw, &vport_num, &esw_owner_vhca_id);
    146 	if (!rep)
    147 		return 0;
    148 
    149 	extack = netdev_notifier_info_to_extack(&info->info);
    150 
    151 	if (mlx5_esw_bridge_is_local(dev, rep, esw))
    152 		err = info->linking ?
    153 			mlx5_esw_bridge_vport_link(ifindex, vport_num, esw_owner_vhca_id,
    154 						   br_offloads, extack) :
    155 			mlx5_esw_bridge_vport_unlink(ifindex, vport_num, esw_owner_vhca_id,
    156 						     br_offloads, extack);
    157 	else if (mlx5_esw_bridge_dev_same_hw(rep, esw))
    158 		err = info->linking ?
    159 			mlx5_esw_bridge_vport_peer_link(ifindex, vport_num, esw_owner_vhca_id,
    160 							br_offloads, extack) :
    161 			mlx5_esw_bridge_vport_peer_unlink(ifindex, vport_num, esw_owner_vhca_id,
    162 							  br_offloads, extack);

No else path?

    163 
--> 164 	return err;
    165 }

regards,
dan carpenter