From: "hch@lst.de" <hch@lst.de>
To: sasaki tatsuya <tatsuya6.sasaki@kioxia.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: update keep alive interval when kato is modified
Date: Wed, 25 Aug 2021 10:53:45 +0200 [thread overview]
Message-ID: <20210825085345.GA31419@lst.de> (raw)
In-Reply-To: <526a1a756d6c4643b15b1b305cc32817@kioxia.com>
Any reason we can't just call this from nvme_passthru_end instead
of inventing a new API? Right now the nvmet passthrough code never
uses the underlying keep alive code, so it doesn't make a difference,
but I expect we'll need more handling for passthrough commands like
this, and we might also grow more users (e.g. the io_uring based
passthrough).
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de>
To: sasaki tatsuya <tatsuya6.sasaki@kioxia.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: update keep alive interval when kato is modified
Date: Wed, 25 Aug 2021 10:53:45 +0200 [thread overview]
Message-ID: <20210825085345.GA31419@lst.de> (raw)
In-Reply-To: <526a1a756d6c4643b15b1b305cc32817@kioxia.com>
Any reason we can't just call this from nvme_passthru_end instead
of inventing a new API? Right now the nvmet passthrough code never
uses the underlying keep alive code, so it doesn't make a difference,
but I expect we'll need more handling for passthrough commands like
this, and we might also grow more users (e.g. the io_uring based
passthrough).
next prev parent reply other threads:[~2021-08-25 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 5:44 [PATCH v2] nvme: update keep alive interval when kato is modified sasaki tatsuya
2021-08-24 5:44 ` sasaki tatsuya
2021-08-24 20:41 ` Sagi Grimberg
2021-08-24 20:41 ` Sagi Grimberg
2021-08-25 8:26 ` sasaki tatsuya
2021-08-25 8:26 ` sasaki tatsuya
2021-08-25 9:04 ` hch
2021-08-25 9:04 ` hch
2021-08-25 8:53 ` hch [this message]
2021-08-25 8:53 ` hch
2021-08-25 15:51 ` Hannes Reinecke
2021-08-25 15:51 ` Hannes Reinecke
2021-08-30 11:27 ` sasaki tatsuya
2021-08-30 11:27 ` sasaki tatsuya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825085345.GA31419@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tatsuya6.sasaki@kioxia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.