From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] tcp: authopt: __tcp_authopt_calc_mac() can be static
Date: Thu, 26 Aug 2021 10:19:46 +0800 [thread overview]
Message-ID: <20210826021946.GA11889@2dc7eb59d52f> (raw)
In-Reply-To: <3e8956d3895a05ca1e7672531cf88b5445b456f3.1629840814.git.cdleonard@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
net/ipv4/tcp_authopt.c:820:5: warning: symbol '__tcp_authopt_calc_mac' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tcp_authopt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/tcp_authopt.c b/net/ipv4/tcp_authopt.c
index 2a3463ad68967..1b81fa54a9f2a 100644
--- a/net/ipv4/tcp_authopt.c
+++ b/net/ipv4/tcp_authopt.c
@@ -817,11 +817,11 @@ static int tcp_authopt_hash_packet(struct crypto_shash *tfm,
return crypto_shash_final(desc, macbuf);
}
-int __tcp_authopt_calc_mac(struct sock *sk,
- struct sk_buff *skb,
- struct tcp_authopt_key_info *key,
- bool input,
- char *macbuf)
+static int __tcp_authopt_calc_mac(struct sock *sk,
+ struct sk_buff *skb,
+ struct tcp_authopt_key_info *key,
+ bool input,
+ char *macbuf)
{
struct crypto_shash *mac_tfm;
u8 traffic_key[TCP_AUTHOPT_MAX_TRAFFIC_KEY_LEN];
next prev parent reply other threads:[~2021-08-26 2:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 21:34 [RFCv3 00/15] tcp: Initial support for RFC5925 auth option Leonard Crestez
2021-08-24 21:34 ` [RFCv3 01/15] tcp: authopt: Initial support and key management Leonard Crestez
2021-08-31 19:04 ` Dmitry Safonov
2021-09-03 14:26 ` Leonard Crestez
2021-08-24 21:34 ` [RFCv3 02/15] docs: Add user documentation for tcp_authopt Leonard Crestez
2021-08-24 21:34 ` [RFCv3 03/15] selftests: Initial tcp_authopt test module Leonard Crestez
2021-08-24 21:34 ` [RFCv3 04/15] selftests: tcp_authopt: Initial sockopt manipulation Leonard Crestez
2021-08-24 21:34 ` [RFCv3 05/15] tcp: authopt: Add crypto initialization Leonard Crestez
2021-08-24 23:02 ` Eric Dumazet
2021-08-24 23:34 ` Eric Dumazet
2021-08-25 8:08 ` Herbert Xu
2021-08-25 14:55 ` Eric Dumazet
2021-08-25 16:04 ` Ard Biesheuvel
2021-08-25 16:31 ` Leonard Crestez
2021-08-25 16:35 ` Leonard Crestez
2021-08-25 17:55 ` Eric Dumazet
2021-08-25 18:56 ` Leonard Crestez
2021-08-24 21:34 ` [RFCv3 06/15] tcp: authopt: Compute packet signatures Leonard Crestez
2021-08-25 0:45 ` kernel test robot
2021-08-26 2:19 ` kernel test robot
2021-08-26 2:19 ` kernel test robot [this message]
2021-08-28 0:39 ` kernel test robot
2021-08-24 21:34 ` [RFCv3 07/15] tcp: authopt: Hook into tcp core Leonard Crestez
2021-08-24 22:59 ` Eric Dumazet
2021-08-25 16:32 ` Leonard Crestez
2021-08-25 1:48 ` kernel test robot
2021-08-25 3:31 ` kernel test robot
2021-08-28 11:59 ` kernel test robot
2021-08-28 11:59 ` [RFC PATCH] tcp: authopt: tcp_authopt_lookup_send() can be static kernel test robot
2021-08-24 21:34 ` [RFCv3 08/15] tcp: authopt: Add snmp counters Leonard Crestez
2021-08-24 21:34 ` [RFCv3 09/15] selftests: tcp_authopt: Test key address binding Leonard Crestez
2021-08-25 5:18 ` David Ahern
2021-08-25 16:37 ` Leonard Crestez
2021-08-24 21:34 ` [RFCv3 10/15] selftests: tcp_authopt: Capture and verify packets Leonard Crestez
2021-08-24 21:34 ` [RFCv3 11/15] selftests: Initial tcp_authopt support for nettest Leonard Crestez
2021-08-24 21:34 ` [RFCv3 12/15] selftests: Initial tcp_authopt support for fcnal-test Leonard Crestez
2021-08-24 21:34 ` [RFCv3 13/15] selftests: Add -t tcp_authopt option for fcnal-test.sh Leonard Crestez
2021-08-24 21:34 ` [RFCv3 14/15] tcp: authopt: Add key selection controls Leonard Crestez
2021-08-24 21:34 ` [RFCv3 15/15] selftests: tcp_authopt: Add tests for rollover Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826021946.GA11889@2dc7eb59d52f \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.