Re: [RFCv3 06/15] tcp: authopt: Compute packet signatures

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2968 bytes --]

Hi Leonard,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on 3a62c333497b164868fdcd241842a1dd4e331825]

url:    https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20210825-053714
base:   3a62c333497b164868fdcd241842a1dd4e331825
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/8666d8497484cd6cb4b94bca9097506d886e9c46
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20210825-053714
        git checkout 8666d8497484cd6cb4b94bca9097506d886e9c46
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> net/ipv4/tcp_authopt.c:606:16: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int @@     got restricted __be32 [usertype] @@
   net/ipv4/tcp_authopt.c:606:16: sparse:     expected unsigned int
   net/ipv4/tcp_authopt.c:606:16: sparse:     got restricted __be32 [usertype]
   net/ipv4/tcp_authopt.c:607:16: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int @@     got restricted __be32 [usertype] @@
   net/ipv4/tcp_authopt.c:607:16: sparse:     expected unsigned int
   net/ipv4/tcp_authopt.c:607:16: sparse:     got restricted __be32 [usertype]
>> net/ipv4/tcp_authopt.c:820:5: sparse: sparse: symbol '__tcp_authopt_calc_mac' was not declared. Should it be static?
   net/ipv4/tcp_authopt.c:128:9: sparse: sparse: context imbalance in 'tcp_authopt_alg_get_tfm' - wrong count at exit
   net/ipv4/tcp_authopt.c:134:9: sparse: sparse: context imbalance in 'tcp_authopt_alg_put_tfm' - unexpected unlock

vim +606 net/ipv4/tcp_authopt.c

   597	
   598	static int tcp_authopt_hash_tcp6_pseudoheader(struct shash_desc *desc,
   599						      struct in6_addr *saddr,
   600						      struct in6_addr *daddr,
   601						      u32 plen)
   602	{
   603		int err;
   604		u32 buf[2];
   605	
 > 606		buf[0] = htonl(plen);
   607		buf[1] = htonl(IPPROTO_TCP);
   608	
   609		err = crypto_shash_update(desc, (u8 *)saddr, sizeof(*saddr));
   610		if (err)
   611			return err;
   612		err = crypto_shash_update(desc, (u8 *)daddr, sizeof(*daddr));
   613		if (err)
   614			return err;
   615		return crypto_shash_update(desc, (u8 *)&buf, sizeof(buf));
   616	}
   617	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42172 bytes --]