Re: [RFC 3/3] media: tw9910: Initialize the entity type

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4617 bytes --]

Hi Fabio,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.14-rc7 next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Fabio-Estevam/media-tw9910-Allow-to-probe-from-device-tree/20210827-210316
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-r001-20210827 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/075fb2f026178ddd4d7d04706f68fd8dff50e22b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Fabio-Estevam/media-tw9910-Allow-to-probe-from-device-tree/20210827-210316
        git checkout 075fb2f026178ddd4d7d04706f68fd8dff50e22b
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=i386 SHELL=/bin/bash drivers/media/i2c/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/i2c/tw9910.c:982:6: error: no member named 'entity' in 'struct v4l2_subdev'
           sd->entity.function = MEDIA_ENT_F_ATV_DECODER;
           ~~  ^
   drivers/media/i2c/tw9910.c:983:36: error: no member named 'entity' in 'struct v4l2_subdev'
           ret = media_entity_pads_init(&sd->entity, 1, &priv->pad);
                                         ~~  ^
   2 errors generated.


vim +982 drivers/media/i2c/tw9910.c

   945	
   946	static int tw9910_probe(struct i2c_client *client,
   947				const struct i2c_device_id *did)
   948	
   949	{
   950		struct tw9910_priv		*priv;
   951		struct i2c_adapter		*adapter = client->adapter;
   952		struct v4l2_subdev *sd;
   953		int ret;
   954	
   955		if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
   956			dev_err(&client->dev,
   957				"I2C-Adapter doesn't support I2C_FUNC_SMBUS_BYTE_DATA\n");
   958			return -EIO;
   959		}
   960	
   961		priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
   962		if (!priv)
   963			return -ENOMEM;
   964	
   965		if (IS_ENABLED(CONFIG_OF) && client->dev.of_node) {
   966			ret = tw9910_parse_dt(client, priv);
   967			if (ret < 0) {
   968				v4l_err(client, "DT parsing error\n");
   969				return ret;
   970			}
   971		} else if (client->dev.platform_data) {
   972			priv->info = client->dev.platform_data;
   973		} else {
   974			v4l_err(client, "No platform data!\n");
   975			return -ENODEV;
   976		}
   977	
   978		sd = &priv->subdev;
   979		v4l2_i2c_subdev_init(sd, client, &tw9910_subdev_ops);
   980		priv->pad.flags = MEDIA_PAD_FL_SOURCE;
   981		sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
 > 982		sd->entity.function = MEDIA_ENT_F_ATV_DECODER;
   983		ret = media_entity_pads_init(&sd->entity, 1, &priv->pad);
   984		if (ret)
   985			return ret;
   986	
   987		priv->clk = clk_get(&client->dev, "xti");
   988		if (PTR_ERR(priv->clk) == -ENOENT) {
   989			priv->clk = NULL;
   990		} else if (IS_ERR(priv->clk)) {
   991			dev_err(&client->dev, "Unable to get xti clock\n");
   992			ret = PTR_ERR(priv->clk);
   993			goto media_entity_cleanup;
   994		}
   995	
   996		priv->pdn_gpio = gpiod_get_optional(&client->dev, "pdn",
   997						    GPIOD_OUT_HIGH);
   998		if (IS_ERR(priv->pdn_gpio)) {
   999			dev_info(&client->dev, "Unable to get GPIO \"pdn\"");
  1000			ret = PTR_ERR(priv->pdn_gpio);
  1001			goto error_clk_put;
  1002		}
  1003	
  1004		ret = tw9910_video_probe(client);
  1005		if (ret < 0)
  1006			goto error_gpio_put;
  1007	
  1008		ret = v4l2_async_register_subdev(&priv->subdev);
  1009		if (ret)
  1010			goto error_gpio_put;
  1011	
  1012		return ret;
  1013	
  1014	error_gpio_put:
  1015		if (priv->pdn_gpio)
  1016			gpiod_put(priv->pdn_gpio);
  1017	error_clk_put:
  1018		clk_put(priv->clk);
  1019		
  1020	media_entity_cleanup:
  1021		media_entity_cleanup(&sd->entity);
  1022		return ret;
  1023	}
  1024	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38034 bytes --]