* [PATCH linux-next] include:ssb: fix boolreturn.cocci warnings
@ 2021-08-24 6:13 CGEL
2021-08-29 11:48 ` [linux-next] ssb: fix boolreturn.cocci warning Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: CGEL @ 2021-08-24 6:13 UTC (permalink / raw)
To: Michael Buesch, linux-wireless, linux-kernel; +Cc: Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
./include/linux/ssb/ssb_driver_extif.h:200:8-9:WARNING: return of 0/1 in
function 'ssb_extif_available' with return type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
include/linux/ssb/ssb_driver_extif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ssb/ssb_driver_extif.h b/include/linux/ssb/ssb_driver_extif.h
index 3f8bc97..19253bf 100644
--- a/include/linux/ssb/ssb_driver_extif.h
+++ b/include/linux/ssb/ssb_driver_extif.h
@@ -197,7 +197,7 @@ struct ssb_extif {
static inline bool ssb_extif_available(struct ssb_extif *extif)
{
- return 0;
+ return false;
}
static inline
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [linux-next] ssb: fix boolreturn.cocci warning
2021-08-24 6:13 [PATCH linux-next] include:ssb: fix boolreturn.cocci warnings CGEL
@ 2021-08-29 11:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-29 11:48 UTC (permalink / raw)
To: CGEL
Cc: Michael Buesch, linux-wireless, linux-kernel, Jing Yangyang,
Zeal Robot
CGEL <cgel.zte@gmail.com> wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> ./include/linux/ssb/ssb_driver_extif.h:200:8-9:WARNING: return of 0/1 in
> function 'ssb_extif_available' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
Patch applied to wireless-drivers-next.git, thanks.
8d4be124062b ssb: fix boolreturn.cocci warning
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210824061341.59255-1-deng.changcheng@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-29 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-24 6:13 [PATCH linux-next] include:ssb: fix boolreturn.cocci warnings CGEL
2021-08-29 11:48 ` [linux-next] ssb: fix boolreturn.cocci warning Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.