From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Eric Dumazet <eric.dumazet@gmail.com>,
kernel-janitors@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org
Subject: Re: [PATCH net 2/2] ipv4: make exception cache less predictible
Date: Mon, 30 Aug 2021 14:34:35 +0300 [thread overview]
Message-ID: <202108301057.8FO7SRFu-lkp@intel.com> (raw)
In-Reply-To: <20210829221615.2057201-3-eric.dumazet@gmail.com>
[ I trimmed the CC list because this is probably a false positive and
netdev hates static checker warnings. - dan ]
Hi Eric,
url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/inet-make-exception-handling-less-predictible/20210830-061726
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 57f780f1c43362b86fd23d20bd940e2468237716
config: x86_64-randconfig-m001-20210829 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/ipv4/route.c:606 fnhe_remove_oldest() error: potentially dereferencing uninitialized 'oldest_p'.
vim +/oldest_p +606 net/ipv4/route.c
adf305d00ec06cb Eric Dumazet 2021-08-29 589 static void fnhe_remove_oldest(struct fnhe_hash_bucket *hash)
4895c771c7f006b David S. Miller 2012-07-17 590 {
adf305d00ec06cb Eric Dumazet 2021-08-29 591 struct fib_nh_exception __rcu **fnhe_p, **oldest_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 592 struct fib_nh_exception *fnhe, *oldest = NULL;
4895c771c7f006b David S. Miller 2012-07-17 593
adf305d00ec06cb Eric Dumazet 2021-08-29 594 for (fnhe_p = &hash->chain; ; fnhe_p = &fnhe->fnhe_next) {
adf305d00ec06cb Eric Dumazet 2021-08-29 595 fnhe = rcu_dereference_protected(*fnhe_p,
adf305d00ec06cb Eric Dumazet 2021-08-29 596 lockdep_is_held(&fnhe_lock));
adf305d00ec06cb Eric Dumazet 2021-08-29 597 if (!fnhe)
adf305d00ec06cb Eric Dumazet 2021-08-29 598 break;
Smatch is complaining that this could break on the first iteration
through the loop...
adf305d00ec06cb Eric Dumazet 2021-08-29 599 if (!oldest ||
adf305d00ec06cb Eric Dumazet 2021-08-29 600 time_before(fnhe->fnhe_stamp, oldest->fnhe_stamp)) {
4895c771c7f006b David S. Miller 2012-07-17 601 oldest = fnhe;
adf305d00ec06cb Eric Dumazet 2021-08-29 602 oldest_p = fnhe_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 603 }
4895c771c7f006b David S. Miller 2012-07-17 604 }
2ffae99d1fac272 Timo Teräs 2013-06-27 605 fnhe_flush_routes(oldest);
adf305d00ec06cb Eric Dumazet 2021-08-29 @606 *oldest_p = oldest->fnhe_next;
adf305d00ec06cb Eric Dumazet 2021-08-29 607 kfree_rcu(oldest, rcu);
4895c771c7f006b David S. Miller 2012-07-17 608 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net 2/2] ipv4: make exception cache less predictible
Date: Mon, 30 Aug 2021 10:39:02 +0800 [thread overview]
Message-ID: <202108301057.8FO7SRFu-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3074 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210829221615.2057201-3-eric.dumazet@gmail.com>
References: <20210829221615.2057201-3-eric.dumazet@gmail.com>
TO: Eric Dumazet <eric.dumazet@gmail.com>
TO: "David S . Miller" <davem@davemloft.net>
TO: Jakub Kicinski <kuba@kernel.org>
CC: netdev <netdev@vger.kernel.org>
CC: Eric Dumazet <edumazet@google.com>
CC: Willy Tarreau <w@1wt.eu>
CC: Keyu Man <kman001@ucr.edu>
CC: David Ahern <dsahern@kernel.org>
Hi Eric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/inet-make-exception-handling-less-predictible/20210830-061726
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 57f780f1c43362b86fd23d20bd940e2468237716
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: x86_64-randconfig-m001-20210829 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/ipv4/route.c:606 fnhe_remove_oldest() error: potentially dereferencing uninitialized 'oldest_p'.
vim +/oldest_p +606 net/ipv4/route.c
2ffae99d1fac272 Timo Teräs 2013-06-27 588
adf305d00ec06cb Eric Dumazet 2021-08-29 589 static void fnhe_remove_oldest(struct fnhe_hash_bucket *hash)
4895c771c7f006b David S. Miller 2012-07-17 590 {
adf305d00ec06cb Eric Dumazet 2021-08-29 591 struct fib_nh_exception __rcu **fnhe_p, **oldest_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 592 struct fib_nh_exception *fnhe, *oldest = NULL;
4895c771c7f006b David S. Miller 2012-07-17 593
adf305d00ec06cb Eric Dumazet 2021-08-29 594 for (fnhe_p = &hash->chain; ; fnhe_p = &fnhe->fnhe_next) {
adf305d00ec06cb Eric Dumazet 2021-08-29 595 fnhe = rcu_dereference_protected(*fnhe_p,
adf305d00ec06cb Eric Dumazet 2021-08-29 596 lockdep_is_held(&fnhe_lock));
adf305d00ec06cb Eric Dumazet 2021-08-29 597 if (!fnhe)
adf305d00ec06cb Eric Dumazet 2021-08-29 598 break;
adf305d00ec06cb Eric Dumazet 2021-08-29 599 if (!oldest ||
adf305d00ec06cb Eric Dumazet 2021-08-29 600 time_before(fnhe->fnhe_stamp, oldest->fnhe_stamp)) {
4895c771c7f006b David S. Miller 2012-07-17 601 oldest = fnhe;
adf305d00ec06cb Eric Dumazet 2021-08-29 602 oldest_p = fnhe_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 603 }
4895c771c7f006b David S. Miller 2012-07-17 604 }
2ffae99d1fac272 Timo Teräs 2013-06-27 605 fnhe_flush_routes(oldest);
adf305d00ec06cb Eric Dumazet 2021-08-29 @606 *oldest_p = oldest->fnhe_next;
adf305d00ec06cb Eric Dumazet 2021-08-29 607 kfree_rcu(oldest, rcu);
4895c771c7f006b David S. Miller 2012-07-17 608 }
4895c771c7f006b David S. Miller 2012-07-17 609
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39595 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net 2/2] ipv4: make exception cache less predictible
Date: Mon, 30 Aug 2021 14:34:35 +0300 [thread overview]
Message-ID: <202108301057.8FO7SRFu-lkp@intel.com> (raw)
In-Reply-To: <20210829221615.2057201-3-eric.dumazet@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2562 bytes --]
[ I trimmed the CC list because this is probably a false positive and
netdev hates static checker warnings. - dan ]
Hi Eric,
url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/inet-make-exception-handling-less-predictible/20210830-061726
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 57f780f1c43362b86fd23d20bd940e2468237716
config: x86_64-randconfig-m001-20210829 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/ipv4/route.c:606 fnhe_remove_oldest() error: potentially dereferencing uninitialized 'oldest_p'.
vim +/oldest_p +606 net/ipv4/route.c
adf305d00ec06cb Eric Dumazet 2021-08-29 589 static void fnhe_remove_oldest(struct fnhe_hash_bucket *hash)
4895c771c7f006b David S. Miller 2012-07-17 590 {
adf305d00ec06cb Eric Dumazet 2021-08-29 591 struct fib_nh_exception __rcu **fnhe_p, **oldest_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 592 struct fib_nh_exception *fnhe, *oldest = NULL;
4895c771c7f006b David S. Miller 2012-07-17 593
adf305d00ec06cb Eric Dumazet 2021-08-29 594 for (fnhe_p = &hash->chain; ; fnhe_p = &fnhe->fnhe_next) {
adf305d00ec06cb Eric Dumazet 2021-08-29 595 fnhe = rcu_dereference_protected(*fnhe_p,
adf305d00ec06cb Eric Dumazet 2021-08-29 596 lockdep_is_held(&fnhe_lock));
adf305d00ec06cb Eric Dumazet 2021-08-29 597 if (!fnhe)
adf305d00ec06cb Eric Dumazet 2021-08-29 598 break;
Smatch is complaining that this could break on the first iteration
through the loop...
adf305d00ec06cb Eric Dumazet 2021-08-29 599 if (!oldest ||
adf305d00ec06cb Eric Dumazet 2021-08-29 600 time_before(fnhe->fnhe_stamp, oldest->fnhe_stamp)) {
4895c771c7f006b David S. Miller 2012-07-17 601 oldest = fnhe;
adf305d00ec06cb Eric Dumazet 2021-08-29 602 oldest_p = fnhe_p;
adf305d00ec06cb Eric Dumazet 2021-08-29 603 }
4895c771c7f006b David S. Miller 2012-07-17 604 }
2ffae99d1fac272 Timo Teräs 2013-06-27 605 fnhe_flush_routes(oldest);
adf305d00ec06cb Eric Dumazet 2021-08-29 @606 *oldest_p = oldest->fnhe_next;
adf305d00ec06cb Eric Dumazet 2021-08-29 607 kfree_rcu(oldest, rcu);
4895c771c7f006b David S. Miller 2012-07-17 608 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next parent reply other threads:[~2021-08-30 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 2:39 kernel test robot [this message]
2021-08-30 11:34 ` [PATCH net 2/2] ipv4: make exception cache less predictible Dan Carpenter
2021-08-30 11:34 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-08-30 17:43 kernel test robot
2021-08-31 7:48 ` kernel test robot
2021-08-31 7:48 ` kernel test robot
2021-08-31 15:13 ` Eric Dumazet
2021-08-31 15:13 ` Eric Dumazet
2021-09-01 5:51 ` kernel test robot
2021-09-01 5:51 ` kernel test robot
2021-08-29 22:16 [PATCH net 0/2] inet: make exception handling " Eric Dumazet
2021-08-29 22:16 ` [PATCH net 1/2] ipv6: make exception cache " Eric Dumazet
2021-08-30 0:39 ` David Ahern
2021-08-30 15:54 ` Wei Wang
2021-08-29 22:16 ` [PATCH net 2/2] ipv4: " Eric Dumazet
2021-08-30 0:40 ` David Ahern
2021-08-30 18:04 ` [PATCH net 0/2] inet: make exception handling " Keyu Man
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108301057.8FO7SRFu-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.