From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Jay Lan <jlan@sgi.com>,
Magnus Damm <magnus.damm@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ia64: Make num_rsvd_regions static
Date: Mon, 06 Sep 2021 07:05:21 +0000 [thread overview]
Message-ID: <20210906070521.GC19281@vergenet.net> (raw)
In-Reply-To: <a377b5437e3e9da93d02f996fe06a2b956cb0990.1629884459.git.geert+renesas@glider.be>
On Wed, Aug 25, 2021 at 01:48:29PM +0200, Geert Uytterhoeven wrote:
> Commit f62800992e5917f2 ("ia64: switch to NO_BOOTMEM") removed the last
> user of num_rsvd_regions outside arch/ia64/kernel/setup.c.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> arch/ia64/include/asm/meminit.h | 1 -
> arch/ia64/kernel/setup.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/ia64/include/asm/meminit.h b/arch/ia64/include/asm/meminit.h
> index 2738f62b5f989492..f1d5bf2ba847a135 100644
> --- a/arch/ia64/include/asm/meminit.h
> +++ b/arch/ia64/include/asm/meminit.h
> @@ -29,7 +29,6 @@ struct rsvd_region {
> };
>
> extern struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1];
> -extern int num_rsvd_regions;
>
> extern void find_memory (void);
> extern void reserve_memory (void);
> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
> index 5e6ee8939092a2df..31fb84de2d21469a 100644
> --- a/arch/ia64/kernel/setup.c
> +++ b/arch/ia64/kernel/setup.c
> @@ -131,7 +131,7 @@ unsigned long ia64_cache_stride_shift = ~0;
> * We use a special marker for the end of memory and it uses the extra (+1) slot
> */
> struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
> -int num_rsvd_regions __initdata;
> +static int num_rsvd_regions __initdata;
>
>
> /*
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Jay Lan <jlan@sgi.com>,
Magnus Damm <magnus.damm@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ia64: Make num_rsvd_regions static
Date: Mon, 6 Sep 2021 09:05:21 +0200 [thread overview]
Message-ID: <20210906070521.GC19281@vergenet.net> (raw)
In-Reply-To: <a377b5437e3e9da93d02f996fe06a2b956cb0990.1629884459.git.geert+renesas@glider.be>
On Wed, Aug 25, 2021 at 01:48:29PM +0200, Geert Uytterhoeven wrote:
> Commit f62800992e5917f2 ("ia64: switch to NO_BOOTMEM") removed the last
> user of num_rsvd_regions outside arch/ia64/kernel/setup.c.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> arch/ia64/include/asm/meminit.h | 1 -
> arch/ia64/kernel/setup.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/ia64/include/asm/meminit.h b/arch/ia64/include/asm/meminit.h
> index 2738f62b5f989492..f1d5bf2ba847a135 100644
> --- a/arch/ia64/include/asm/meminit.h
> +++ b/arch/ia64/include/asm/meminit.h
> @@ -29,7 +29,6 @@ struct rsvd_region {
> };
>
> extern struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1];
> -extern int num_rsvd_regions;
>
> extern void find_memory (void);
> extern void reserve_memory (void);
> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
> index 5e6ee8939092a2df..31fb84de2d21469a 100644
> --- a/arch/ia64/kernel/setup.c
> +++ b/arch/ia64/kernel/setup.c
> @@ -131,7 +131,7 @@ unsigned long ia64_cache_stride_shift = ~0;
> * We use a special marker for the end of memory and it uses the extra (+1) slot
> */
> struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
> -int num_rsvd_regions __initdata;
> +static int num_rsvd_regions __initdata;
>
>
> /*
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-06 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 11:48 [PATCH 0/3] ia64: Miscellaneous fixes and cleanups Geert Uytterhoeven
2021-08-25 11:48 ` Geert Uytterhoeven
2021-08-25 11:48 ` [PATCH 1/3] ia64: Fix #endif comment for reserve_elfcorehdr() Geert Uytterhoeven
2021-08-25 11:48 ` Geert Uytterhoeven
2021-09-06 7:03 ` Simon Horman
2021-09-06 7:03 ` Simon Horman
2021-08-25 11:48 ` [PATCH 2/3] ia64: Make reserve_elfcorehdr() static Geert Uytterhoeven
2021-08-25 11:48 ` Geert Uytterhoeven
2021-09-06 7:07 ` Simon Horman
2021-09-06 7:07 ` Simon Horman
2021-08-25 11:48 ` [PATCH 3/3] ia64: Make num_rsvd_regions static Geert Uytterhoeven
2021-08-25 11:48 ` Geert Uytterhoeven
2021-09-06 7:05 ` Simon Horman [this message]
2021-09-06 7:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906070521.GC19281@vergenet.net \
--to=horms@verge.net.au \
--cc=akpm@linux-foundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jlan@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.