From: kernel test robot <lkp@intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
Alan Stern <stern@rowland.harvard.edu>
Cc: kbuild-all@lists.01.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] usb: ehci: Simplify platform driver registration
Date: Tue, 7 Sep 2021 18:56:13 +0800 [thread overview]
Message-ID: <202109071816.ALAT868S-lkp@intel.com> (raw)
In-Reply-To: <20210907044527.2137211-1-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 3117 bytes --]
Hi Guenter,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.14 next-20210907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-randconfig-r023-20210906 (attached as .config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bd9aa6646a29d48171474905fedca85ac7ff6ce5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
git checkout bd9aa6646a29d48171474905fedca85ac7ff6ce5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_init':
>> drivers/usb/host/ehci-hcd.c:1340:18: error: implicit declaration of function 'platform_register_drivers'; did you mean 'pci_register_driver'? [-Werror=implicit-function-declaration]
1340 | retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| pci_register_driver
drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_cleanup':
>> drivers/usb/host/ehci-hcd.c:1357:9: error: implicit declaration of function 'platform_unregister_drivers'; did you mean 'pci_unregister_driver'? [-Werror=implicit-function-declaration]
1357 | platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pci_unregister_driver
cc1: some warnings being treated as errors
vim +1340 drivers/usb/host/ehci-hcd.c
1339
> 1340 retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
1341 if (retval < 0)
1342 goto clean0;
1343 return 0;
1344
1345 clean0:
1346 #ifdef CONFIG_DYNAMIC_DEBUG
1347 debugfs_remove(ehci_debug_root);
1348 ehci_debug_root = NULL;
1349 #endif
1350 clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
1351 return retval;
1352 }
1353 module_init(ehci_hcd_init);
1354
1355 static void __exit ehci_hcd_cleanup(void)
1356 {
> 1357 platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35624 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] usb: ehci: Simplify platform driver registration
Date: Tue, 07 Sep 2021 18:56:13 +0800 [thread overview]
Message-ID: <202109071816.ALAT868S-lkp@intel.com> (raw)
In-Reply-To: <20210907044527.2137211-1-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 3186 bytes --]
Hi Guenter,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.14 next-20210907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-randconfig-r023-20210906 (attached as .config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bd9aa6646a29d48171474905fedca85ac7ff6ce5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
git checkout bd9aa6646a29d48171474905fedca85ac7ff6ce5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_init':
>> drivers/usb/host/ehci-hcd.c:1340:18: error: implicit declaration of function 'platform_register_drivers'; did you mean 'pci_register_driver'? [-Werror=implicit-function-declaration]
1340 | retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| pci_register_driver
drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_cleanup':
>> drivers/usb/host/ehci-hcd.c:1357:9: error: implicit declaration of function 'platform_unregister_drivers'; did you mean 'pci_unregister_driver'? [-Werror=implicit-function-declaration]
1357 | platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pci_unregister_driver
cc1: some warnings being treated as errors
vim +1340 drivers/usb/host/ehci-hcd.c
1339
> 1340 retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
1341 if (retval < 0)
1342 goto clean0;
1343 return 0;
1344
1345 clean0:
1346 #ifdef CONFIG_DYNAMIC_DEBUG
1347 debugfs_remove(ehci_debug_root);
1348 ehci_debug_root = NULL;
1349 #endif
1350 clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
1351 return retval;
1352 }
1353 module_init(ehci_hcd_init);
1354
1355 static void __exit ehci_hcd_cleanup(void)
1356 {
> 1357 platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35624 bytes --]
next prev parent reply other threads:[~2021-09-07 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 4:45 [PATCH] usb: ehci: Simplify platform driver registration Guenter Roeck
2021-09-07 6:37 ` kernel test robot
2021-09-07 6:37 ` kernel test robot
2021-09-07 10:56 ` kernel test robot [this message]
2021-09-07 10:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109071816.ALAT868S-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.