Re: [PATCH v8 07/15] media: amphion: implement vpu core communication based on mailbox

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

Hi Ming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 9c3a0f285248899dfa81585bc5d5bc9ebdb8fead]

url:    https://github.com/0day-ci/linux/commits/Ming-Qian/amphion-video-decoder-encoder-driver/20210907-175342
base:   9c3a0f285248899dfa81585bc5d5bc9ebdb8fead
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f1cf0764ca594c8a3eb242cd0d82177b69f62dd0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Qian/amphion-video-decoder-encoder-driver/20210907-175342
        git checkout f1cf0764ca594c8a3eb242cd0d82177b69f62dd0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/media/platform/amphion/vpu_cmds.c: In function 'vpu_core_sw_reset':
>> drivers/media/platform/amphion/vpu_cmds.c:435:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     435 | }
         | ^


vim +435 drivers/media/platform/amphion/vpu_cmds.c

   411	
   412	int vpu_core_sw_reset(struct vpu_core *core)
   413	{
   414		struct vpu_rpc_event pkt;
   415		int ret;
   416	
   417		WARN_ON(!core);
   418	
   419		memset(&pkt, 0, sizeof(pkt));
   420		vpu_iface_pack_cmd(core, &pkt, 0, VPU_CMD_ID_FIRM_RESET, NULL);
   421	
   422		reinit_completion(&core->cmp);
   423		mutex_lock(&core->cmd_lock);
   424		ret = vpu_cmd_send(core, &pkt);
   425		mutex_unlock(&core->cmd_lock);
   426		if (ret)
   427			return ret;
   428		ret = wait_for_completion_timeout(&core->cmp, VPU_TIMEOUT);
   429		if (!ret) {
   430			vpu_err("core[%d] sw reset timeout\n", core->id);
   431			return -EINVAL;
   432		}
   433	
   434		return 0;
 > 435	}

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54075 bytes --]