From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alex.bou9@gmail.com>,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
Ira Weiny <ira.weiny@intel.com>,
John Hubbard <jhubbard@nvidia.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Date: Thu, 9 Sep 2021 18:52:27 -0700 [thread overview]
Message-ID: <202109091849.53C9A8AD@keescook> (raw)
In-Reply-To: <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org>
On Thu, Sep 09, 2021 at 04:11:09PM -0700, Andrew Morton wrote:
> On Thu, 9 Sep 2021 15:51:23 -0700 Kees Cook <keescook@chromium.org> wrote:
>
> > > That's an "error", not a warning. Or is this thanks to the new -Werror?
> >
> > This is a "regular" error (__bad_copy_to() uses __compiletime_error()).
> >
> > > Either way, I'm inclined to cc:stable on this, because use of gcc-9 on
> > > older kernels will be a common thing down the ages.
> > >
> > > If it's really an "error" on non-Werror kernels then definitely cc:stable.
> >
> > I would expect that as only being needed if __alloc_size was backported
> > to -stable, which seems unlikely.
>
> Ah. Changelog didn't tell me that it's an __alloc_size thing.
Er, it's in the Subject, but I guess I could repeat it?
> What's the status of the __alloc_size() patchset, btw?
It's in -next via -mm, and all is well as far as I know:
compiler-attributes-add-__alloc_size-for-better-bounds-checking.patch
compiler-attributes-add-__alloc_size-for-better-bounds-checking-fix.patch
checkpatch-add-__alloc_size-to-known-attribute.patch
slab-clean-up-function-declarations.patch
slab-add-__alloc_size-attributes-for-better-bounds-checking.patch
mm-page_alloc-add-__alloc_size-attributes-for-better-bounds-checking.patch
percpu-add-__alloc_size-attributes-for-better-bounds-checking.patch
mm-vmalloc-add-__alloc_size-attributes-for-better-bounds-checking.patch
FWIW, I had extensively checked (and fixed) warnings from it before sending it
your way. This patch is fixing an error that just appeared from
randconfig.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-09-10 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 16:14 [PATCH] rapidio: Avoid bogus __alloc_size warning Kees Cook
2021-09-09 20:27 ` Andrew Morton
2021-09-09 22:26 ` John Hubbard
2021-09-09 22:51 ` Kees Cook
2021-09-09 23:11 ` Andrew Morton
2021-09-10 1:52 ` Kees Cook [this message]
2021-09-10 4:50 ` Dan Carpenter
2021-09-10 5:48 ` Andrew Morton
2021-09-10 6:29 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109091849.53C9A8AD@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alex.bou9@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gustavoars@kernel.org \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=jingxiangfeng@huawei.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.