From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
kernel test robot <lkp@intel.com>,
Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alex.bou9@gmail.com>,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
Ira Weiny <ira.weiny@intel.com>,
John Hubbard <jhubbard@nvidia.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Date: Thu, 9 Sep 2021 23:29:18 -0700 [thread overview]
Message-ID: <202109092327.C582B074C@keescook> (raw)
In-Reply-To: <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org>
On Thu, Sep 09, 2021 at 10:48:14PM -0700, Andrew Morton wrote:
> On Fri, 10 Sep 2021 07:50:10 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > This is how the email looks like to Andrew.
> >
> > https://sylpheed.sraoss.jp/images/sylpheed2-mainwindow.png
> >
> > Try to find the subject in that nonsense. Same for everyone else on
> > email as well.
> >
> > https://marc.info/?l=linux-kernel&m=163120404328790&w=2
> >
> > I only either read the subject or the body of the commit message and
> > never both. :P
>
> I read the body if the subject looks relevant ;)
>
> But that subject reads to me as "rapidio: Avoid bogus *blah* warning".
> We have soooooo many alloc_foo functions that one's eyes glaze over
> something like "alloc_size"
>
> Why? Because the identifier "__alloc_size" is of great significance
> to Kees because he wrote the thing. Everyone else just sees "*blah*".
Heh. Okay, fair enough. I will make Subject/body independent. It felt
redundant to me before, but greater verbosity is a good idea. Sorry!
--
Kees Cook
prev parent reply other threads:[~2021-09-10 6:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 16:14 [PATCH] rapidio: Avoid bogus __alloc_size warning Kees Cook
2021-09-09 20:27 ` Andrew Morton
2021-09-09 22:26 ` John Hubbard
2021-09-09 22:51 ` Kees Cook
2021-09-09 23:11 ` Andrew Morton
2021-09-10 1:52 ` Kees Cook
2021-09-10 4:50 ` Dan Carpenter
2021-09-10 5:48 ` Andrew Morton
2021-09-10 6:29 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109092327.C582B074C@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alex.bou9@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gustavoars@kernel.org \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=jingxiangfeng@huawei.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.