All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH mcgrof] selftests: first_test_dev can be static
Date: Sun, 12 Sep 2021 10:46:57 +0800	[thread overview]
Message-ID: <20210912024657.GA9363@da1845d11521> (raw)
In-Reply-To: <202109121025.Nvy9Ygs2-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

lib/test_sysfs.c:148:26: warning: symbol 'first_test_dev' was not declared. Should it be static?

Fixes: ed2111f617d4 ("selftests: add tests_sysfs module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 test_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_sysfs.c b/lib/test_sysfs.c
index f8935bd678b12..273fc3f397401 100644
--- a/lib/test_sysfs.c
+++ b/lib/test_sysfs.c
@@ -145,7 +145,7 @@ struct sysfs_test_device {
 	int y;
 };
 
-struct sysfs_test_device *first_test_dev;
+static struct sysfs_test_device *first_test_dev;
 
 static struct miscdevice *dev_to_misc_dev(struct device *dev)
 {

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH mcgrof] selftests: first_test_dev can be static
Date: Sun, 12 Sep 2021 10:46:57 +0800	[thread overview]
Message-ID: <20210912024657.GA9363@da1845d11521> (raw)
In-Reply-To: <202109121025.Nvy9Ygs2-lkp@intel.com>

lib/test_sysfs.c:148:26: warning: symbol 'first_test_dev' was not declared. Should it be static?

Fixes: ed2111f617d4 ("selftests: add tests_sysfs module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 test_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_sysfs.c b/lib/test_sysfs.c
index f8935bd678b12..273fc3f397401 100644
--- a/lib/test_sysfs.c
+++ b/lib/test_sysfs.c
@@ -145,7 +145,7 @@ struct sysfs_test_device {
 	int y;
 };
 
-struct sysfs_test_device *first_test_dev;
+static struct sysfs_test_device *first_test_dev;
 
 static struct miscdevice *dev_to_misc_dev(struct device *dev)
 {

  reply	other threads:[~2021-09-12  2:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12  2:46 [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static? kernel test robot
2021-09-12  2:46 ` kernel test robot
2021-09-12  2:46 ` kernel test robot [this message]
2021-09-12  2:46   ` [RFC PATCH mcgrof] selftests: first_test_dev can be static kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210912024657.GA9363@da1845d11521 \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.