Re: [RFC PATCH 4/4] PCI/ASPM: Remove unncessary linked list defined within aspm.c

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3122 bytes --]

Hi "Saheed,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.15-rc1 next-20210916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Saheed-O-Bolarinwa/PCI-ASPM-Remove-struct-pcie_link_state-parent/20210916-175210
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-buildonly-randconfig-r002-20210916 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a2a494c1e1531309518be74ed2e406334b716fbe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Saheed-O-Bolarinwa/PCI-ASPM-Remove-struct-pcie_link_state-parent/20210916-175210
        git checkout a2a494c1e1531309518be74ed2e406334b716fbe
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pcie/aspm.c:963:35: warning: variable 'link' is uninitialized when used here [-Wuninitialized]
                   dev->link_state->aspm_capable = link->aspm_support;
                                                   ^~~~
   drivers/pci/pcie/aspm.c:960:30: note: initialize the variable 'link' to silence this warning
           struct pcie_link_state *link;
                                       ^
                                        = NULL
   1 warning generated.


vim +/link +963 drivers/pci/pcie/aspm.c

   954	
   955	/* Recheck latencies and update aspm_capable for links under the root */
   956	static void pcie_update_aspm_capable(struct pcie_link_state *root)
   957	{
   958		struct pci_dev *dev;
   959		struct pci_bus *rootbus = root->pdev->bus;
   960		struct pcie_link_state *link;
   961		BUG_ON(root->pdev->bus->parent->self);
   962		list_for_each_entry(dev, &rootbus->devices, bus_list) {
 > 963			dev->link_state->aspm_capable = link->aspm_support;
   964		}
   965	
   966		list_for_each_entry(dev, &rootbus->devices, bus_list) {
   967			struct pci_dev *child;
   968			struct pci_bus *linkbus = dev->subordinate;
   969	
   970			list_for_each_entry(child, &linkbus->devices, bus_list) {
   971				if ((pci_pcie_type(child) != PCI_EXP_TYPE_ENDPOINT) &&
   972				    (pci_pcie_type(child) != PCI_EXP_TYPE_LEG_END))
   973					continue;
   974				pcie_aspm_check_latency(child);
   975			}
   976		}
   977	}
   978	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44159 bytes --]