From: Jorge Maidana <jorgem.seq@gmail.com>
To: linux-media@vger.kernel.org
Cc: hverkuil-cisco@xs4all.nl, Jorge Maidana <jorgem.seq@gmail.com>
Subject: [PATCH] qv4l2: enable the play action on non-streaming radio rx
Date: Fri, 17 Sep 2021 17:47:15 -0300 [thread overview]
Message-ID: <20210917204715.3663-1-jorgem.seq@gmail.com> (raw)
The commit 37f42eb35d87 ("qv4l2: reorganize colorspace handling")
disabled the play action on non-streaming devices.
This patch enables the play action 'm_capStartAct' on non-streaming
radio rx (audio-only) devices, assuming that 'isCapture' should exclude
radio tx. In addition, it also disables the step-frame action
'm_capStepAct' on radio devices.
Signed-off-by: Jorge Maidana <jorgem.seq@gmail.com>
---
utils/qv4l2/qv4l2.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utils/qv4l2/qv4l2.cpp b/utils/qv4l2/qv4l2.cpp
index b57178e4..d9141ad1 100644
--- a/utils/qv4l2/qv4l2.cpp
+++ b/utils/qv4l2/qv4l2.cpp
@@ -456,9 +456,9 @@ void ApplicationWindow::setDevice(const QString &device, bool rawOpen)
else
m_convertData = v4lconvert_create(g_fd());
bool canStream = has_rw() || has_streaming();
- bool isCapture = v4l_type_is_capture(g_type());
- m_capStartAct->setEnabled(canStream);
- m_capStepAct->setEnabled(canStream && isCapture);
+ bool isCapture = v4l_type_is_capture(g_type()) && !has_radio_tx();
+ m_capStartAct->setEnabled(canStream || isCapture);
+ m_capStepAct->setEnabled(canStream && isCapture && !has_radio_rx());
m_saveRawAct->setEnabled(canStream && has_vid_cap());
m_snapshotAct->setEnabled(canStream && has_vid_cap());
m_capMenu->setEnabled(canStream && isCapture && !has_radio_rx());
--
2.30.2
reply other threads:[~2021-09-17 20:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917204715.3663-1-jorgem.seq@gmail.com \
--to=jorgem.seq@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.