All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qv4l2: enable the play action on non-streaming radio rx
@ 2021-09-17 20:47 Jorge Maidana
  0 siblings, 0 replies; only message in thread
From: Jorge Maidana @ 2021-09-17 20:47 UTC (permalink / raw)
  To: linux-media; +Cc: hverkuil-cisco, Jorge Maidana

The commit 37f42eb35d87 ("qv4l2: reorganize colorspace handling")
disabled the play action on non-streaming devices.

This patch enables the play action 'm_capStartAct' on non-streaming
radio rx (audio-only) devices, assuming that 'isCapture' should exclude
radio tx. In addition, it also disables the step-frame action
'm_capStepAct' on radio devices.

Signed-off-by: Jorge Maidana <jorgem.seq@gmail.com>
---
 utils/qv4l2/qv4l2.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/utils/qv4l2/qv4l2.cpp b/utils/qv4l2/qv4l2.cpp
index b57178e4..d9141ad1 100644
--- a/utils/qv4l2/qv4l2.cpp
+++ b/utils/qv4l2/qv4l2.cpp
@@ -456,9 +456,9 @@ void ApplicationWindow::setDevice(const QString &device, bool rawOpen)
 	else
 		m_convertData = v4lconvert_create(g_fd());
 	bool canStream = has_rw() || has_streaming();
-	bool isCapture = v4l_type_is_capture(g_type());
-	m_capStartAct->setEnabled(canStream);
-	m_capStepAct->setEnabled(canStream && isCapture);
+	bool isCapture = v4l_type_is_capture(g_type()) && !has_radio_tx();
+	m_capStartAct->setEnabled(canStream || isCapture);
+	m_capStepAct->setEnabled(canStream && isCapture && !has_radio_rx());
 	m_saveRawAct->setEnabled(canStream && has_vid_cap());
 	m_snapshotAct->setEnabled(canStream && has_vid_cap());
 	m_capMenu->setEnabled(canStream && isCapture && !has_radio_rx());
-- 
2.30.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-17 20:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-17 20:47 [PATCH] qv4l2: enable the play action on non-streaming radio rx Jorge Maidana

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.