All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-imx@nxp.com
Subject: Re: [PATCH v2] ARM: imx6: mask all interrupts before calling stby-poweroff sequence
Date: Wed, 22 Sep 2021 10:37:40 +0800	[thread overview]
Message-ID: <20210922023740.GD10217@dragon> (raw)
In-Reply-To: <20210817122500.31953-1-o.rempel@pengutronix.de>

On Tue, Aug 17, 2021 at 02:25:00PM +0200, Oleksij Rempel wrote:
> Any pending interrupt can prevent entering standby based power off state.
> To avoid it, mask all interrupts.
> 
> Fixes: 8148d2136002 ("ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/mach-imx/pm-imx6.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> index 9244437cb1b9..63887ade411a 100644
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -59,8 +59,11 @@
>  #define MX6Q_SUSPEND_OCRAM_SIZE		0x1000
>  #define MX6_MAX_MMDC_IO_NUM		33
>  
> +#define GIC_DIST_ENABLE_CLEAR		0x180
> +
>  static void __iomem *ccm_base;
>  static void __iomem *suspend_ocram_base;
> +static void __iomem *gic_raw_dist_base;
>  static void (*imx6_suspend_in_ocram_fn)(void __iomem *ocram_vbase);
>  
>  /*
> @@ -592,6 +595,7 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
>  static void __init imx6_pm_common_init(const struct imx6_pm_socdata
>  					*socdata)
>  {
> +	struct device_node *np;
>  	struct regmap *gpr;
>  	int ret;
>  
> @@ -615,10 +619,29 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata
>  	if (!IS_ERR(gpr))
>  		regmap_update_bits(gpr, IOMUXC_GPR1, IMX6Q_GPR1_GINT,
>  				   IMX6Q_GPR1_GINT);
> +
> +	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> +	gic_raw_dist_base = of_iomap(np, 0);
> +}
> +
> +static void imx_gic_mask_all(void)
> +{
> +	int i;
> +
> +	if (WARN_ON(!gic_raw_dist_base))
> +		return;
> +
> +	for (i = 0; i < 4; i++)
> +		writel_relaxed(~0, gic_raw_dist_base + GIC_DIST_ENABLE_CLEAR + 4 * i);

Is it possible to have a helper function in GIC driver, that we can
simply call into?

Shawn

>  }
>  
>  static void imx6_pm_stby_poweroff(void)
>  {
> +	/*
> +	 * A pending interrupt can prevent power off signal to be activated.
> +	 * So, mask all interrupts to avoid it.
> +	 */
> +	imx_gic_mask_all();
>  	imx6_set_lpm(STOP_POWER_OFF);
>  	imx6q_suspend_finish(0);
>  
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-imx@nxp.com
Subject: Re: [PATCH v2] ARM: imx6: mask all interrupts before calling stby-poweroff sequence
Date: Wed, 22 Sep 2021 10:37:40 +0800	[thread overview]
Message-ID: <20210922023740.GD10217@dragon> (raw)
In-Reply-To: <20210817122500.31953-1-o.rempel@pengutronix.de>

On Tue, Aug 17, 2021 at 02:25:00PM +0200, Oleksij Rempel wrote:
> Any pending interrupt can prevent entering standby based power off state.
> To avoid it, mask all interrupts.
> 
> Fixes: 8148d2136002 ("ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/mach-imx/pm-imx6.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> index 9244437cb1b9..63887ade411a 100644
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -59,8 +59,11 @@
>  #define MX6Q_SUSPEND_OCRAM_SIZE		0x1000
>  #define MX6_MAX_MMDC_IO_NUM		33
>  
> +#define GIC_DIST_ENABLE_CLEAR		0x180
> +
>  static void __iomem *ccm_base;
>  static void __iomem *suspend_ocram_base;
> +static void __iomem *gic_raw_dist_base;
>  static void (*imx6_suspend_in_ocram_fn)(void __iomem *ocram_vbase);
>  
>  /*
> @@ -592,6 +595,7 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
>  static void __init imx6_pm_common_init(const struct imx6_pm_socdata
>  					*socdata)
>  {
> +	struct device_node *np;
>  	struct regmap *gpr;
>  	int ret;
>  
> @@ -615,10 +619,29 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata
>  	if (!IS_ERR(gpr))
>  		regmap_update_bits(gpr, IOMUXC_GPR1, IMX6Q_GPR1_GINT,
>  				   IMX6Q_GPR1_GINT);
> +
> +	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> +	gic_raw_dist_base = of_iomap(np, 0);
> +}
> +
> +static void imx_gic_mask_all(void)
> +{
> +	int i;
> +
> +	if (WARN_ON(!gic_raw_dist_base))
> +		return;
> +
> +	for (i = 0; i < 4; i++)
> +		writel_relaxed(~0, gic_raw_dist_base + GIC_DIST_ENABLE_CLEAR + 4 * i);

Is it possible to have a helper function in GIC driver, that we can
simply call into?

Shawn

>  }
>  
>  static void imx6_pm_stby_poweroff(void)
>  {
> +	/*
> +	 * A pending interrupt can prevent power off signal to be activated.
> +	 * So, mask all interrupts to avoid it.
> +	 */
> +	imx_gic_mask_all();
>  	imx6_set_lpm(STOP_POWER_OFF);
>  	imx6q_suspend_finish(0);
>  
> -- 
> 2.30.2
> 

  reply	other threads:[~2021-09-22  2:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 12:25 [PATCH v2] ARM: imx6: mask all interrupts before calling stby-poweroff sequence Oleksij Rempel
2021-08-17 12:25 ` Oleksij Rempel
2021-09-22  2:37 ` Shawn Guo [this message]
2021-09-22  2:37   ` Shawn Guo
2021-09-22  2:57   ` Florian Fainelli
2021-09-22  2:57     ` Florian Fainelli
2021-09-28 13:39     ` Oleksij Rempel
2021-09-28 13:39       ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922023740.GD10217@dragon \
    --to=shawnguo@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.