All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/amd/display: Fix randomly flicking on overlay with enabled ABM
@ 2021-09-24  1:34 yipeng.chen
  0 siblings, 0 replies; only message in thread
From: yipeng.chen @ 2021-09-24  1:34 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, qingqing.zhuo, Aric.Cyr, Anson.Jacob, bindu.r,
	martin.tsai, bing.guo, roy.chan, george.shen, joshua.aberback,
	Ashley.Thomas2, Jing.Zhou, dale.zhao
  Cc: amd-gfx, dri-devel, linux-kernel, ching-shih.li,
	Yipeng Chen (Jasber), Roman Li, Anthony Koo

From: "Yipeng Chen (Jasber)" <yipeng.chen@amd.com>

[Why]
Enabled ABM (level != 0) would raise short pulse irq DC_IRQ_SOURCE_HPD1RX
randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging
on EDP panel. After correcting CRC error, there is no need to send drm
hotplug event.

[How]
Returning false would skip doing hot-plug when handle_hpd_irq_psr_sink()
handled irq. Hot-plug process causes visible flicking on overlay.

Signed-off-by: Yipeng Chen (Jasber) <yipeng.chen@amd.com>
Reviewed-by: Roman Li <Roman.Li@amd.com>
Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 1e4794e2825c..9b9fbe5e9bd4 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -3007,7 +3007,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
 
 	if (handle_hpd_irq_psr_sink(link))
 		/* PSR-related error was detected and handled */
-		return true;
+		return false;
 
 	/* If PSR-related error handled, Main link may be off,
 	 * so do not handle as a normal sink status change interrupt.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-24  1:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-24  1:34 [PATCH v2] drm/amd/display: Fix randomly flicking on overlay with enabled ABM yipeng.chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.