All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, Colin Xu <colin.xu@intel.com>,
	linux-doc@vger.kernel.org
Subject: drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Tue, 28 Sep 2021 06:13:13 +0800	[thread overview]
Message-ID: <202109280604.lsuCTD7N-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3962 bytes --]

Hi Zhenyu,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   92477dd1faa650e50bd3bb35a6c0b8d09198cc35
commit: 145e06b58f8625becc61792a0554726314297a85 drm/i915/gvt: Move mdev attribute groups into kvmgt module
date:   4 months ago
config: x86_64-randconfig-a016-20210927 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=145e06b58f8625becc61792a0554726314297a85
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 145e06b58f8625becc61792a0554726314297a85
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Check if can do 2M page
   drivers/gpu/drm/i915/gvt/gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead


vim +1152 drivers/gpu/drm/i915/gvt/gtt.c

2707e44466881d6 Zhi Wang          2016-03-28  1150  
b901b252b6cf5ce Changbin Du       2018-05-15  1151  /**
a752b070a678231 Zhenyu Wang       2018-07-31 @1152   * Check if can do 2M page
a752b070a678231 Zhenyu Wang       2018-07-31  1153   * @vgpu: target vgpu
a752b070a678231 Zhenyu Wang       2018-07-31  1154   * @entry: target pfn's gtt entry
a752b070a678231 Zhenyu Wang       2018-07-31  1155   *
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1156   * Return 1 if 2MB huge gtt shadowing is possible, 0 if miscondition,
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1157   * negative if found err.
b901b252b6cf5ce Changbin Du       2018-05-15  1158   */
b901b252b6cf5ce Changbin Du       2018-05-15  1159  static int is_2MB_gtt_possible(struct intel_vgpu *vgpu,
b901b252b6cf5ce Changbin Du       2018-05-15  1160  	struct intel_gvt_gtt_entry *entry)
b901b252b6cf5ce Changbin Du       2018-05-15  1161  {
b901b252b6cf5ce Changbin Du       2018-05-15  1162  	struct intel_gvt_gtt_pte_ops *ops = vgpu->gvt->gtt.pte_ops;
b901b252b6cf5ce Changbin Du       2018-05-15  1163  	unsigned long pfn;
b901b252b6cf5ce Changbin Du       2018-05-15  1164  
a61ac1e75105a07 Chris Wilson      2020-03-06  1165  	if (!HAS_PAGE_SIZES(vgpu->gvt->gt->i915, I915_GTT_PAGE_SIZE_2M))
b901b252b6cf5ce Changbin Du       2018-05-15  1166  		return 0;
b901b252b6cf5ce Changbin Du       2018-05-15  1167  
b901b252b6cf5ce Changbin Du       2018-05-15  1168  	pfn = intel_gvt_hypervisor_gfn_to_mfn(vgpu, ops->get_pfn(entry));
b901b252b6cf5ce Changbin Du       2018-05-15  1169  	if (pfn == INTEL_GVT_INVALID_ADDR)
b901b252b6cf5ce Changbin Du       2018-05-15  1170  		return -EINVAL;
b901b252b6cf5ce Changbin Du       2018-05-15  1171  
b901b252b6cf5ce Changbin Du       2018-05-15  1172  	return PageTransHuge(pfn_to_page(pfn));
b901b252b6cf5ce Changbin Du       2018-05-15  1173  }
b901b252b6cf5ce Changbin Du       2018-05-15  1174  

:::::: The code at line 1152 was first introduced by commit
:::::: a752b070a67823174565322cc48b2668daf9a8da drm/i915/gvt: Fix function comment doc errors

:::::: TO: Zhenyu Wang <zhenyuw@linux.intel.com>
:::::: CC: Zhenyu Wang <zhenyuw@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37699 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Tue, 28 Sep 2021 06:13:13 +0800	[thread overview]
Message-ID: <202109280604.lsuCTD7N-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4031 bytes --]

Hi Zhenyu,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   92477dd1faa650e50bd3bb35a6c0b8d09198cc35
commit: 145e06b58f8625becc61792a0554726314297a85 drm/i915/gvt: Move mdev attribute groups into kvmgt module
date:   4 months ago
config: x86_64-randconfig-a016-20210927 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=145e06b58f8625becc61792a0554726314297a85
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 145e06b58f8625becc61792a0554726314297a85
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Check if can do 2M page
   drivers/gpu/drm/i915/gvt/gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead


vim +1152 drivers/gpu/drm/i915/gvt/gtt.c

2707e44466881d6 Zhi Wang          2016-03-28  1150  
b901b252b6cf5ce Changbin Du       2018-05-15  1151  /**
a752b070a678231 Zhenyu Wang       2018-07-31 @1152   * Check if can do 2M page
a752b070a678231 Zhenyu Wang       2018-07-31  1153   * @vgpu: target vgpu
a752b070a678231 Zhenyu Wang       2018-07-31  1154   * @entry: target pfn's gtt entry
a752b070a678231 Zhenyu Wang       2018-07-31  1155   *
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1156   * Return 1 if 2MB huge gtt shadowing is possible, 0 if miscondition,
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1157   * negative if found err.
b901b252b6cf5ce Changbin Du       2018-05-15  1158   */
b901b252b6cf5ce Changbin Du       2018-05-15  1159  static int is_2MB_gtt_possible(struct intel_vgpu *vgpu,
b901b252b6cf5ce Changbin Du       2018-05-15  1160  	struct intel_gvt_gtt_entry *entry)
b901b252b6cf5ce Changbin Du       2018-05-15  1161  {
b901b252b6cf5ce Changbin Du       2018-05-15  1162  	struct intel_gvt_gtt_pte_ops *ops = vgpu->gvt->gtt.pte_ops;
b901b252b6cf5ce Changbin Du       2018-05-15  1163  	unsigned long pfn;
b901b252b6cf5ce Changbin Du       2018-05-15  1164  
a61ac1e75105a07 Chris Wilson      2020-03-06  1165  	if (!HAS_PAGE_SIZES(vgpu->gvt->gt->i915, I915_GTT_PAGE_SIZE_2M))
b901b252b6cf5ce Changbin Du       2018-05-15  1166  		return 0;
b901b252b6cf5ce Changbin Du       2018-05-15  1167  
b901b252b6cf5ce Changbin Du       2018-05-15  1168  	pfn = intel_gvt_hypervisor_gfn_to_mfn(vgpu, ops->get_pfn(entry));
b901b252b6cf5ce Changbin Du       2018-05-15  1169  	if (pfn == INTEL_GVT_INVALID_ADDR)
b901b252b6cf5ce Changbin Du       2018-05-15  1170  		return -EINVAL;
b901b252b6cf5ce Changbin Du       2018-05-15  1171  
b901b252b6cf5ce Changbin Du       2018-05-15  1172  	return PageTransHuge(pfn_to_page(pfn));
b901b252b6cf5ce Changbin Du       2018-05-15  1173  }
b901b252b6cf5ce Changbin Du       2018-05-15  1174  

:::::: The code at line 1152 was first introduced by commit
:::::: a752b070a67823174565322cc48b2668daf9a8da drm/i915/gvt: Fix function comment doc errors

:::::: TO: Zhenyu Wang <zhenyuw@linux.intel.com>
:::::: CC: Zhenyu Wang <zhenyuw@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37699 bytes --]

             reply	other threads:[~2021-09-27 22:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 22:13 kernel test robot [this message]
2021-09-27 22:13 ` drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-11-06 21:01 kernel test robot
2021-11-06 21:01 ` kernel test robot
2021-11-19 10:38 kernel test robot
2021-11-19 10:38 ` kernel test robot
2022-01-10 12:21 kernel test robot
2022-01-10 12:21 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109280604.lsuCTD7N-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=colin.xu@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.