[meta-tpm][v2][PATCH] swtpm: fix build issues of missing expect

[meta-tpm][v2][PATCH] swtpm: fix build issues of missing expect

[Armin Kuster]

Signed-off-by: Armin Kuster <akuster808@gmail.com>

--
V2]
Only need expect-native
Clean up PACKAGECONFGI[gnutils] to conform to spec
---
 meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
index 807c02b..0087367 100644
--- a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
+++ b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fe8092c832b71ef20dfe4c6d3decb3a8"
 SECTION = "apps"
 
 # coreutils-native and net-tools-native are reportedly only required for the tests
-DEPENDS = "libtasn1 coreutils-native expect socat glib-2.0 net-tools-native libtpm json-glib"
+DEPENDS = "libtasn1 coreutils-native expect-native socat glib-2.0 net-tools-native libtpm json-glib"
 
 SRCREV = "98187d24fe14851653a7c46eb16e9c5f0b9beaa1"
 SRC_URI = "git://github.com/stefanberger/swtpm.git;branch=stable-0.6 \
@@ -28,7 +28,7 @@ PACKAGECONFIG[openssl] = "--with-openssl, --without-openssl, openssl"
 # expect, bash, tpm2-pkcs11-tools (tpm2_ptool), tpmtool and certtool is
 # used by swtpm-create-tpmca (the last two is provided by gnutls)
 # gnutls is required by: swtpm-create-tpmca, swtpm-localca and swtpm_cert
-PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls, expect bash tpm2-pkcs11-tools"
+PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls expect bash tpm2-pkcs11-tools"
 PACKAGECONFIG[selinux] = "--with-selinux, --without-selinux, libselinux"
 PACKAGECONFIG[cuse] = "--with-cuse, --without-cuse, fuse"
 PACKAGECONFIG[seccomp] = "--with-seccomp, --without-seccomp, libseccomp"
-- 
2.25.1

Re: [yocto] [meta-tpm][v2][PATCH] swtpm: fix build issues of missing expect

[Kristian Klausen]

Den Fri, Oct 01, 2021 at 15:25:17 -0700 skrev Armin Kuster:
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> 
> --
> V2]
> Only need expect-native
> Clean up PACKAGECONFGI[gnutils] to conform to spec
> ---
>  meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> index 807c02b..0087367 100644
> --- a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> +++ b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fe8092c832b71ef20dfe4c6d3decb3a8"
>  SECTION = "apps"
>  
>  # coreutils-native and net-tools-native are reportedly only required for the tests
> -DEPENDS = "libtasn1 coreutils-native expect socat glib-2.0 net-tools-native libtpm json-glib"
> +DEPENDS = "libtasn1 coreutils-native expect-native socat glib-2.0 net-tools-native libtpm json-glib"
>  
>  SRCREV = "98187d24fe14851653a7c46eb16e9c5f0b9beaa1"
>  SRC_URI = "git://github.com/stefanberger/swtpm.git;branch=stable-0.6 \
> @@ -28,7 +28,7 @@ PACKAGECONFIG[openssl] = "--with-openssl, --without-openssl, openssl"
>  # expect, bash, tpm2-pkcs11-tools (tpm2_ptool), tpmtool and certtool is
>  # used by swtpm-create-tpmca (the last two is provided by gnutls)
>  # gnutls is required by: swtpm-create-tpmca, swtpm-localca and swtpm_cert
> -PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls, expect bash tpm2-pkcs11-tools"
> +PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls expect bash tpm2-pkcs11-tools"

Hi Armin

Support for RRECOMMENDS in the PACKAGECONFIG was added some years 
ago[1][2]. Whatever they should be RRECOMMENDS or RDEPENDS I'm not sure 
about (I don't think swtpm-create-tpmca is a hard requirement for most 
people).

If you like I can squash the changes into my own patch and resend it.

[1] https://git.openembedded.org/openembedded-core/commit/?id=ec96c985ce1c888c3ce3c4d964d7a106c3c88a5c
[2] https://www.yoctoproject.org/docs/latest/ref-manual/ref-manual.html#var-PACKAGECONFIG

Cheers,
Kristian

>  PACKAGECONFIG[selinux] = "--with-selinux, --without-selinux, libselinux"
>  PACKAGECONFIG[cuse] = "--with-cuse, --without-cuse, fuse"
>  PACKAGECONFIG[seccomp] = "--with-seccomp, --without-seccomp, libseccomp"
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#54928): https://lists.yoctoproject.org/g/yocto/message/54928
> Mute This Topic: https://lists.yoctoproject.org/mt/86012566/6376886
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [kristian@klausen.dk]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [yocto] [meta-tpm][v2][PATCH] swtpm: fix build issues of missing expect

[akuster808]

On 10/1/21 4:06 PM, Kristian Klausen wrote:
> Den Fri, Oct 01, 2021 at 15:25:17 -0700 skrev Armin Kuster:
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>>
>> --
>> V2]
>> Only need expect-native
>> Clean up PACKAGECONFGI[gnutils] to conform to spec
>> ---
>>  meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
>> index 807c02b..0087367 100644
>> --- a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
>> +++ b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
>> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fe8092c832b71ef20dfe4c6d3decb3a8"
>>  SECTION = "apps"
>>  
>>  # coreutils-native and net-tools-native are reportedly only required for the tests
>> -DEPENDS = "libtasn1 coreutils-native expect socat glib-2.0 net-tools-native libtpm json-glib"
>> +DEPENDS = "libtasn1 coreutils-native expect-native socat glib-2.0 net-tools-native libtpm json-glib"
>>  
>>  SRCREV = "98187d24fe14851653a7c46eb16e9c5f0b9beaa1"
>>  SRC_URI = "git://github.com/stefanberger/swtpm.git;branch=stable-0.6 \
>> @@ -28,7 +28,7 @@ PACKAGECONFIG[openssl] = "--with-openssl, --without-openssl, openssl"
>>  # expect, bash, tpm2-pkcs11-tools (tpm2_ptool), tpmtool and certtool is
>>  # used by swtpm-create-tpmca (the last two is provided by gnutls)
>>  # gnutls is required by: swtpm-create-tpmca, swtpm-localca and swtpm_cert
>> -PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls, expect bash tpm2-pkcs11-tools"
>> +PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls expect bash tpm2-pkcs11-tools"
> Hi Armin
>
> Support for RRECOMMENDS in the PACKAGECONFIG was added some years 
> ago[1][2]. Whatever they should be RRECOMMENDS or RDEPENDS I'm not sure 
> about (I don't think swtpm-create-tpmca is a hard requirement for most 
> people).
>
> If you like I can squash the changes into my own patch and resend it.

Please do, that sounds great.

-armin
>
> [1] https://git.openembedded.org/openembedded-core/commit/?id=ec96c985ce1c888c3ce3c4d964d7a106c3c88a5c
> [2] https://www.yoctoproject.org/docs/latest/ref-manual/ref-manual.html#var-PACKAGECONFIG
>
> Cheers,
> Kristian
>
>>  PACKAGECONFIG[selinux] = "--with-selinux, --without-selinux, libselinux"
>>  PACKAGECONFIG[cuse] = "--with-cuse, --without-cuse, fuse"
>>  PACKAGECONFIG[seccomp] = "--with-seccomp, --without-seccomp, libseccomp"
>> -- 
>> 2.25.1
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#54928): https://lists.yoctoproject.org/g/yocto/message/54928
>> Mute This Topic: https://lists.yoctoproject.org/mt/86012566/6376886
>> Group Owner: yocto+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [kristian@klausen.dk]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>