All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Logan Gunthorpe <logang@deltatee.com>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Stephen Bates <sbates@raithlin.com>,
	David Sloan <David.Sloan@eideticom.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [RFC PATCH] nvme: allow specific passthrough IOs without CAP_SYSADMIN
Date: Sun, 3 Oct 2021 12:18:57 +0200	[thread overview]
Message-ID: <20211003101857.GA10943@lst.de> (raw)
In-Reply-To: <f1e00f76-235a-e4b0-ce98-3eabe0a50ea3@grimberg.me>

On Sun, Oct 03, 2021 at 12:29:22PM +0300, Sagi Grimberg wrote:
>> Users that want to send any of these passthrough commands will still
>> require access to the NVMe char device or namespace. Typically, the
>> char device is only accessible by root anyway and namespaces are
>> accessible by root and the disk group. Administrators are free to
>> add udev rules to adjust these permissions for specific devices they
>> want to allow.
>
> I don't understand what is the difference between VS commands and normal
> commands? Why do you consider VS commands safe to relax privileges as
> opposed to any other command?

They are different in that it is cometely undefine what they do.
So relaxing that checks is an absolute non-starter while for simple
things like Read it might be possible if we really care.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Logan Gunthorpe <logang@deltatee.com>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Stephen Bates <sbates@raithlin.com>,
	David Sloan <David.Sloan@eideticom.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [RFC PATCH] nvme: allow specific passthrough IOs without CAP_SYSADMIN
Date: Sun, 3 Oct 2021 12:18:57 +0200	[thread overview]
Message-ID: <20211003101857.GA10943@lst.de> (raw)
In-Reply-To: <f1e00f76-235a-e4b0-ce98-3eabe0a50ea3@grimberg.me>

On Sun, Oct 03, 2021 at 12:29:22PM +0300, Sagi Grimberg wrote:
>> Users that want to send any of these passthrough commands will still
>> require access to the NVMe char device or namespace. Typically, the
>> char device is only accessible by root anyway and namespaces are
>> accessible by root and the disk group. Administrators are free to
>> add udev rules to adjust these permissions for specific devices they
>> want to allow.
>
> I don't understand what is the difference between VS commands and normal
> commands? Why do you consider VS commands safe to relax privileges as
> opposed to any other command?

They are different in that it is cometely undefine what they do.
So relaxing that checks is an absolute non-starter while for simple
things like Read it might be possible if we really care.

  reply	other threads:[~2021-10-03 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 23:40 [RFC PATCH] nvme: allow specific passthrough IOs without CAP_SYSADMIN Logan Gunthorpe
2021-10-01 23:40 ` Logan Gunthorpe
2021-10-03  9:29 ` Sagi Grimberg
2021-10-03  9:29   ` Sagi Grimberg
2021-10-03 10:18   ` Christoph Hellwig [this message]
2021-10-03 10:18     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211003101857.GA10943@lst.de \
    --to=hch@lst.de \
    --cc=David.Sloan@eideticom.com \
    --cc=axboe@fb.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=martin.oliveira@eideticom.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.