From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Yangbo Lu <yangbo.lu@nxp.com>, Yinbo Zhu <yinbo.zhu@nxp.com>,
Ashish Kumar <Ashish.Kumar@nxp.com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix eSDHC2 node
Date: Mon, 4 Oct 2021 20:42:47 +0800 [thread overview]
Message-ID: <20211004124246.GI15650@dragon> (raw)
In-Reply-To: <20210915202259.3000923-1-michael@walle.cc>
On Wed, Sep 15, 2021 at 10:22:59PM +0200, Michael Walle wrote:
> On the LS1028A this instance of the eSDHC controller is intended for
> either an eMMC or eSDIO card. It doesn't provide a card detect pin and
> its IO voltage is fixed at 1.8V.
>
> Remove the bogus broken-cd property, instead add the non-removable
> property. Fix the voltage-ranges property and set it to 1.8V only.
>
> Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Yangbo Lu <yangbo.lu@nxp.com>, Yinbo Zhu <yinbo.zhu@nxp.com>,
Ashish Kumar <Ashish.Kumar@nxp.com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix eSDHC2 node
Date: Mon, 4 Oct 2021 20:42:47 +0800 [thread overview]
Message-ID: <20211004124246.GI15650@dragon> (raw)
In-Reply-To: <20210915202259.3000923-1-michael@walle.cc>
On Wed, Sep 15, 2021 at 10:22:59PM +0200, Michael Walle wrote:
> On the LS1028A this instance of the eSDHC controller is intended for
> either an eMMC or eSDIO card. It doesn't provide a card detect pin and
> its IO voltage is fixed at 1.8V.
>
> Remove the bogus broken-cd property, instead add the non-removable
> property. Fix the voltage-ranges property and set it to 1.8V only.
>
> Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks!
next prev parent reply other threads:[~2021-10-04 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:22 [PATCH] arm64: dts: ls1028a: fix eSDHC2 node Michael Walle
2021-09-15 20:22 ` Michael Walle
2021-10-04 12:42 ` Shawn Guo [this message]
2021-10-04 12:42 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004124246.GI15650@dragon \
--to=shawnguo@kernel.org \
--cc=Ashish.Kumar@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=yangbo.lu@nxp.com \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.