All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Morten Linderud <morten@linderud.pw>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined
Date: Mon, 4 Oct 2021 20:02:45 +0200	[thread overview]
Message-ID: <20211004200245.04d12431@endymion> (raw)
In-Reply-To: <20210919100851.2890107-1-morten@linderud.pw>

Hi Morten,

On Sun, 19 Sep 2021 12:08:51 +0200, Morten Linderud wrote:
> If we are building to a defined destdir py-smbus is going to ignore this
> and try install to the actual root. This breaks packaging setups as the
> install section would fail.
> 
> Signed-off-by: Morten Linderud <morten@linderud.pw>
> ---
>  py-smbus/Module.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/py-smbus/Module.mk b/py-smbus/Module.mk
> index 04ceb64..1e2ded1 100644
> --- a/py-smbus/Module.mk
> +++ b/py-smbus/Module.mk
> @@ -22,7 +22,7 @@ clean-python:
>  	rm -rf py-smbus/build
>  
>  install-python:
> -	$(DISTUTILS) install
> +	$(DISTUTILS) install --prefix="$(PREFIX)"
>  
>  all: all-python
>  

Thanks for catching and fixing this. Applied.

-- 
Jean Delvare
SUSE L3 Support

      parent reply	other threads:[~2021-10-04 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 10:08 [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined Morten Linderud
2021-10-02  6:43 ` Wolfram Sang
2021-10-04 18:02 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004200245.04d12431@endymion \
    --to=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=morten@linderud.pw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.