From: Wolfram Sang <wsa@kernel.org>
To: Morten Linderud <morten@linderud.pw>, Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined
Date: Sat, 2 Oct 2021 08:43:59 +0200 [thread overview]
Message-ID: <YVf/r7SQlBQI2g39@kunai> (raw)
In-Reply-To: <20210919100851.2890107-1-morten@linderud.pw>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Sun, Sep 19, 2021 at 12:08:51PM +0200, Morten Linderud wrote:
> If we are building to a defined destdir py-smbus is going to ignore this
> and try install to the actual root. This breaks packaging setups as the
> install section would fail.
>
> Signed-off-by: Morten Linderud <morten@linderud.pw>
Looks good to me, adding Jean.
> ---
> py-smbus/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/py-smbus/Module.mk b/py-smbus/Module.mk
> index 04ceb64..1e2ded1 100644
> --- a/py-smbus/Module.mk
> +++ b/py-smbus/Module.mk
> @@ -22,7 +22,7 @@ clean-python:
> rm -rf py-smbus/build
>
> install-python:
> - $(DISTUTILS) install
> + $(DISTUTILS) install --prefix="$(PREFIX)"
>
> all: all-python
>
> --
> 2.33.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-02 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 10:08 [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined Morten Linderud
2021-10-02 6:43 ` Wolfram Sang [this message]
2021-10-04 18:02 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVf/r7SQlBQI2g39@kunai \
--to=wsa@kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=morten@linderud.pw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.