Re: [Buildroot] [PATCH 1/1] package/pecl-dbus: new package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Hervé,

Thanks for this contribution!

On Tue,  5 Oct 2021 15:11:21 +0200
Herve Codina <herve.codina@bootlin.com> wrote:

> The pecl-dbus package provides a PHP extension for interaction
> with D-Bus busses.
> 
> https://github.com/derickr/pecl-dbus
> 
> Based on initial work from Nicolas Carrier <nicolas.carrier@orolia.com>
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
>  DEVELOPERS                                    |   6 +
>  package/Config.in                             |   1 +
>  package/pecl-dbus/0001-php8-compat.patch      | 161 ++++++++++++++++++
>  ...lity-with-php8-call_user_function_ex.patch |  31 ++++
>  package/pecl-dbus/Config.in                   |  15 ++
>  package/pecl-dbus/pecl-dbus.hash              |   3 +
>  package/pecl-dbus/pecl-dbus.mk                |  25 +++
>  .../testing/tests/package/test_pecl_dbus.py   |  32 ++++
>  8 files changed, 274 insertions(+)

Thanks for this new package. I'm just wondering about the package name.
The upstream project is indeed named pecl-dbus, where pecl stands for
"PHP Extension Community Library". But all our other PHP packages are
named "php-<something>". Should we name this package "php-dbus" ?
"php-pecl-dbus" ?


> diff --git a/package/pecl-dbus/0001-php8-compat.patch b/package/pecl-dbus/0001-php8-compat.patch
> new file mode 100644
> index 0000000000..bef9a1fa05
> --- /dev/null
> +++ b/package/pecl-dbus/0001-php8-compat.patch
> @@ -0,0 +1,161 @@
> +From 7fde4dd4d26d2a4b7957a1010c6ea9e4b940fc62 Mon Sep 17 00:00:00 2001
> +From: Stefan Saraev <stefan@saraev.ca>
> +Date: Mon, 18 Jan 2021 23:22:52 +0200
> +Subject: [PATCH] php8 compat
> +
> +This patch was retrieved from the pending upstream pull request
> +done by Stefan Saraev.
> +https://github.com/derickr/pecl-dbus/pull/8
> +
> +Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Perhaps you could just ping on this pull request, to say that it also
solved the problem for you?

> diff --git a/package/pecl-dbus/0002-Fix-compatibility-with-php8-call_user_function_ex.patch b/package/pecl-dbus/0002-Fix-compatibility-with-php8-call_user_function_ex.patch
> new file mode 100644
> index 0000000000..1e579e4272
> --- /dev/null
> +++ b/package/pecl-dbus/0002-Fix-compatibility-with-php8-call_user_function_ex.patch
> @@ -0,0 +1,31 @@
> +From 8cf66c4b5dd657ca14552b27a42901db0a5e9280 Mon Sep 17 00:00:00 2001
> +From: Herve Codina <herve.codina@bootlin.com>
> +Date: Mon, 4 Oct 2021 17:13:45 +0200
> +Subject: [PATCH] Fix compatibility with php8 - call_user_function_ex
> +
> +This patch fix compatibility with php8 replacing
> +call_user_function_ex by call_user_function.
> +
> +Signed-off-by: Herve Codina <herve.codina@bootlin.com>

And submit this upstream ?

> diff --git a/package/pecl-dbus/Config.in b/package/pecl-dbus/Config.in
> new file mode 100644
> index 0000000000..a531397754
> --- /dev/null
> +++ b/package/pecl-dbus/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_PECL_DBUS
> +	bool "pecl-dbus"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
> +	depends on BR2_USE_MMU # dbus
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_PHP_EXT_LIBXML2 # Runtime dependency

I was wondering if you need both BR2_PACKAGE_LIBXML2 and
BR2_PACKAGE_PHP_EXT_LIBXML2, i.e does pecl-dbus link directly with the
libxml2 native library ?


> +PECL_DBUS_VERSION = 315d17558c7614d02e923d898231e51c86a25789
> +PECL_DBUS_SITE = $(call github,derickr,pecl-dbus,$(PECL_DBUS_VERSION))
> +PECL_DBUS_LICENSE = PHP-3.01
> +PECL_DBUS_LICENSE_FILES = LICENSE
> +PECL_DBUS_DEPENDENCIES = php dbus libxml2 host-autoconf host-pkgconf
> +
> +PECL_DBUS_CONF_OPTS = \
> +	--with-php-config=$(STAGING_DIR)/usr/bin/php-config \
> +	--enable-dbus

pecl-dbus can build without dbus ?!?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot