From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pecl-dbus: new package
Date: Fri, 8 Oct 2021 15:16:53 +0200 [thread overview]
Message-ID: <20211008151653.6be74611@windsurf> (raw)
In-Reply-To: <20211005181523.085d94b8@bootlin.com>
Hello,
On Tue, 5 Oct 2021 18:15:23 +0200
Herve Codina <herve.codina@bootlin.com> wrote:
> > Thanks for this new package. I'm just wondering about the package name.
> > The upstream project is indeed named pecl-dbus, where pecl stands for
> > "PHP Extension Community Library". But all our other PHP packages are
> > named "php-<something>". Should we name this package "php-dbus" ?
> > "php-pecl-dbus" ?
>
> "php-pecl-dbus" sounds good.
> If it's ok for everyone, I will change in v2.
Fine with me. As said, I'm fine with either php-dbus or php-pecl-dbus.
> > > +Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> >
> > And submit this upstream ?
>
> I did too.
👍
> > I was wondering if you need both BR2_PACKAGE_LIBXML2 and
> > BR2_PACKAGE_PHP_EXT_LIBXML2, i.e does pecl-dbus link directly with the
> > libxml2 native library ?
>
> libxml2 is needed. In dbus.c source file, we have
> #include "libxml/parser.h"
> #include "libxml/parserInternals.h"
> and calls to libxml2 functions such as 'xmlParseMemory()'
So, confirms that it links with libxml2 directly, indeed!
> > pecl-dbus can build without dbus ?!?
>
> Indeed, '--enable-dbus' is not needed and will be removed in v2.
ACK, perfect.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-08 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 13:11 [Buildroot] [PATCH 1/1] package/pecl-dbus: new package Herve Codina
2021-10-05 13:53 ` Thomas Petazzoni
2021-10-05 16:15 ` Herve Codina
2021-10-08 13:16 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008151653.6be74611@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=herve.codina@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.