All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue
Date: Mon, 11 Oct 2021 13:39:11 +0200	[thread overview]
Message-ID: <20211011113911.GA16138@lst.de> (raw)
In-Reply-To: <YVu3EjPqT8VME/oY@T590>

On Tue, Oct 05, 2021 at 10:23:14AM +0800, Ming Lei wrote:
> On Fri, Oct 01, 2021 at 05:56:04AM +0000, Chaitanya Kulkarni wrote:
> > On 9/30/2021 5:56 AM, Ming Lei wrote:
> > > External email: Use caution opening links or attachments
> > > 
> > > 
> > > Add two APIs for stopping and starting admin queue.
> > > 
> > > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > 
> > 
> > this patch looks good to me, but from the feedback I've received in past 
> > we need to add the new functions in the patch where they are actually 
> > used than adding it in a separate patch.

The above is for use inside the same driver/subsystem.  Cross-subsystem
we usually do what Ming did here.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue
Date: Mon, 11 Oct 2021 13:39:11 +0200	[thread overview]
Message-ID: <20211011113911.GA16138@lst.de> (raw)
In-Reply-To: <YVu3EjPqT8VME/oY@T590>

On Tue, Oct 05, 2021 at 10:23:14AM +0800, Ming Lei wrote:
> On Fri, Oct 01, 2021 at 05:56:04AM +0000, Chaitanya Kulkarni wrote:
> > On 9/30/2021 5:56 AM, Ming Lei wrote:
> > > External email: Use caution opening links or attachments
> > > 
> > > 
> > > Add two APIs for stopping and starting admin queue.
> > > 
> > > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > 
> > 
> > this patch looks good to me, but from the feedback I've received in past 
> > we need to add the new functions in the patch where they are actually 
> > used than adding it in a separate patch.

The above is for use inside the same driver/subsystem.  Cross-subsystem
we usually do what Ming did here.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-10-11 11:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 12:56 [PATCH V2 0/5] blk-mq: support concurrent queue quiescing Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue Ming Lei
2021-09-30 12:56   ` Ming Lei
2021-10-01  5:56   ` Chaitanya Kulkarni
2021-10-01  5:56     ` Chaitanya Kulkarni
2021-10-05  2:23     ` Ming Lei
2021-10-05  2:23       ` Ming Lei
2021-10-05  3:38       ` Chaitanya Kulkarni
2021-10-05  3:38         ` Chaitanya Kulkarni
2021-10-05  8:04         ` Ming Lei
2021-10-05  8:04           ` Ming Lei
2021-10-11 11:39       ` Christoph Hellwig [this message]
2021-10-11 11:39         ` Christoph Hellwig
2021-10-13  4:25         ` Chaitanya Kulkarni
2021-10-13  4:25           ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 2/5] nvme: apply nvme API to quiesce/unquiesce " Ming Lei
2021-09-30 12:56   ` Ming Lei
2021-10-01  5:57   ` Chaitanya Kulkarni
2021-10-01  5:57     ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 3/5] nvme: prepare for pairing quiescing and unquiescing Ming Lei
2021-09-30 12:56   ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 4/5] nvme: paring quiesce/unquiesce Ming Lei
2021-09-30 12:56   ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 5/5] blk-mq: support concurrent queue quiesce/unquiesce Ming Lei
2021-09-30 12:56   ` Ming Lei
2021-09-30 15:56   ` Bart Van Assche
2021-09-30 15:56     ` Bart Van Assche
2021-10-05  2:31     ` Ming Lei
2021-10-05  2:31       ` Ming Lei
2021-10-08  3:22       ` yukuai (C)
2021-10-08  3:22         ` yukuai (C)
2021-10-08  5:10         ` Ming Lei
2021-10-08  5:10           ` Ming Lei
2021-10-08  6:22           ` yukuai (C)
2021-10-08  6:22             ` yukuai (C)
2021-10-08  6:35             ` Ming Lei
2021-10-08  6:35               ` Ming Lei
2021-10-08  7:13               ` yukuai (C)
2021-10-08  7:13                 ` yukuai (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011113911.GA16138@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.