From: kernel test robot <lkp@intel.com>
To: Denis Pauk <pauk.denis@gmail.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
eugene.shalygin@gmail.com, andy.shevchenko@gmail.com,
pauk.denis@gmail.com, platform-driver-x86@vger.kernel.org,
Tor Vic <torvic9@mailbox.org>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
Date: Mon, 11 Oct 2021 11:05:41 +0800 [thread overview]
Message-ID: <202110111159.pfJSa3ml-lkp@intel.com> (raw)
In-Reply-To: <20211010210513.343925-2-pauk.denis@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2912 bytes --]
Hi Denis,
I love your patch! Yet something to improve:
[auto build test ERROR on 39b483aa38995329326988cbc4077422bebc175a]
url: https://github.com/0day-ci/linux/commits/Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
base: 39b483aa38995329326988cbc4077422bebc175a
config: x86_64-randconfig-r033-20211011 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 903b30fea21f99d8f48fde4defcc838970e30ee1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4ac420ec20a4c088ebd178ab3d4a345de53b91a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
git checkout 4ac420ec20a4c088ebd178ab3d4a345de53b91a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/hwmon/asus_wmi_ec_sensors.c:356:11: error: implicit declaration of function 'wmi_evaluate_method' [-Werror,-Wimplicit-function-declaration]
status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
^
drivers/hwmon/asus_wmi_ec_sensors.c:356:11: note: did you mean 'wmidev_evaluate_method'?
include/linux/wmi.h:24:20: note: 'wmidev_evaluate_method' declared here
extern acpi_status wmidev_evaluate_method(struct wmi_device *wdev,
^
1 error generated.
vim +/wmi_evaluate_method +356 drivers/hwmon/asus_wmi_ec_sensors.c
344
345 static int asus_wmi_ec_block_read(u32 method_id, char *query, u8 *out)
346 {
347 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER,
348 NULL };
349 struct acpi_buffer input;
350 union acpi_object *obj;
351 acpi_status status;
352
353 /* the first byte of the BRxx() argument string has to be the string size */
354 input.length = (acpi_size)query[0] + 2;
355 input.pointer = query;
> 356 status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
357 &output);
358 if (ACPI_FAILURE(status))
359 return -EIO;
360
361 obj = output.pointer;
362 if (!obj || obj->type != ACPI_TYPE_BUFFER) {
363 if (!obj)
364 acpi_os_free(output.pointer);
365
366 return -EIO;
367 }
368 asus_wmi_ec_decode_reply_buffer(obj->buffer.pointer, out);
369 acpi_os_free(output.pointer);
370 return 0;
371 }
372
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38700 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
Date: Mon, 11 Oct 2021 11:05:41 +0800 [thread overview]
Message-ID: <202110111159.pfJSa3ml-lkp@intel.com> (raw)
In-Reply-To: <20211010210513.343925-2-pauk.denis@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2984 bytes --]
Hi Denis,
I love your patch! Yet something to improve:
[auto build test ERROR on 39b483aa38995329326988cbc4077422bebc175a]
url: https://github.com/0day-ci/linux/commits/Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
base: 39b483aa38995329326988cbc4077422bebc175a
config: x86_64-randconfig-r033-20211011 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 903b30fea21f99d8f48fde4defcc838970e30ee1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4ac420ec20a4c088ebd178ab3d4a345de53b91a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
git checkout 4ac420ec20a4c088ebd178ab3d4a345de53b91a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/hwmon/asus_wmi_ec_sensors.c:356:11: error: implicit declaration of function 'wmi_evaluate_method' [-Werror,-Wimplicit-function-declaration]
status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
^
drivers/hwmon/asus_wmi_ec_sensors.c:356:11: note: did you mean 'wmidev_evaluate_method'?
include/linux/wmi.h:24:20: note: 'wmidev_evaluate_method' declared here
extern acpi_status wmidev_evaluate_method(struct wmi_device *wdev,
^
1 error generated.
vim +/wmi_evaluate_method +356 drivers/hwmon/asus_wmi_ec_sensors.c
344
345 static int asus_wmi_ec_block_read(u32 method_id, char *query, u8 *out)
346 {
347 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER,
348 NULL };
349 struct acpi_buffer input;
350 union acpi_object *obj;
351 acpi_status status;
352
353 /* the first byte of the BRxx() argument string has to be the string size */
354 input.length = (acpi_size)query[0] + 2;
355 input.pointer = query;
> 356 status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
357 &output);
358 if (ACPI_FAILURE(status))
359 return -EIO;
360
361 obj = output.pointer;
362 if (!obj || obj->type != ACPI_TYPE_BUFFER) {
363 if (!obj)
364 acpi_os_free(output.pointer);
365
366 return -EIO;
367 }
368 asus_wmi_ec_decode_reply_buffer(obj->buffer.pointer, out);
369 acpi_os_free(output.pointer);
370 return 0;
371 }
372
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38700 bytes --]
next prev parent reply other threads:[~2021-10-11 3:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 21:05 [PATCH v4 0/2] Update ASUS WMI supported boards Denis Pauk
2021-10-10 21:05 ` [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI Denis Pauk
2021-10-10 22:09 ` Eugene Shalygin
2021-10-10 23:51 ` Guenter Roeck
2021-10-11 2:04 ` kernel test robot
2021-10-11 2:04 ` kernel test robot
2021-10-11 3:05 ` kernel test robot [this message]
2021-10-11 3:05 ` kernel test robot
2021-10-10 21:05 ` [PATCH v4 2/2] hwmon: (asus_wmi_sensors) Support X370 " Denis Pauk
2021-10-10 23:32 ` kernel test robot
2021-10-10 23:32 ` kernel test robot
2021-10-11 2:53 ` kernel test robot
2021-10-11 2:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110111159.pfJSa3ml-lkp@intel.com \
--to=lkp@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=pauk.denis@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=torvic9@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.