All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Lysov <arzamas-16@mail.ee>
To: Kewei Xu <kewei.xu@mediatek.com>
Cc: <linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
	<matthias.bgg@gmail.com>, <qii.wang@mediatek.com>
Subject: Re: [PATCH v8 2/5] i2c: mediatek: Dump i2c/dma register when a timeout occurs
Date: Mon, 11 Oct 2021 18:38:14 +0300	[thread overview]
Message-ID: <20211011183814.488ed866@pc> (raw)

On Sun, 10 Oct 2021 15:05:13 +0800
Kewei Xu <kewei.xu@mediatek.com> wrote:

> When a timeout error occurs in i2c transter, it is usually related
> to the i2c/dma IP hardware configuration. Therefore, the purpose of
> this patch is to dump the key register values of i2c/dma when a
> timeout occurs in i2c for debugging.
> 
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: Qii Wang <qii.wang@mediatek.com>

I would like to test this patchset on one of supported platforms, an
mt6577-powered device. This driver requires a DMA base...
> 	i2c->pdmabase = devm_ioremap_resource(&pdev->dev, res);
>	if (IS_ERR(i2c->pdmabase))
>		return PTR_ERR(i2c->pdmabase);
... however I am not sure what address should I specify in the .dts file. While
other i2c busses supported by this driver such as mt6589 [1][2] and mt6797 [3]
have designated DMA for I2C, mt6577 seems to lack dedicated DMA engine for I2C
[4][5].

Do I need to specify the Generic DMA base address [4] instead?

Worth mentioning I brought up this issue in the past [5][6].

[1] ALPS.KK1.MP5.V1.3_EASTAEON89_WET_KK source code (downstream)
[2] MT6589 HSPA+ Smartphone Application Processor Datasheet v1.0, page 869
[3] MT6797 LTE-A Smartphone Application Processor Register Table (Part 1) v1.1,
page 1796
[4] MT6577 HSPA Smartphone Application Processor Datasheet v0.94, page 547
[5] ALPS.JB.MP.V1.19_MBK77_TB_JB source code (downstream)
[6] https://marc.info/?l=devicetree&m=159949247901831&w=2
[7] https://marc.info/?l=linux-i2c&m=159939730714187&w=2

WARNING: multiple messages have this Message-ID (diff)
From: Boris Lysov <arzamas-16@mail.ee>
To: Kewei Xu <kewei.xu@mediatek.com>
Cc: <linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
	<matthias.bgg@gmail.com>, <qii.wang@mediatek.com>
Subject: Re: [PATCH v8 2/5] i2c: mediatek: Dump i2c/dma register when a timeout occurs
Date: Mon, 11 Oct 2021 18:38:14 +0300	[thread overview]
Message-ID: <20211011183814.488ed866@pc> (raw)

On Sun, 10 Oct 2021 15:05:13 +0800
Kewei Xu <kewei.xu@mediatek.com> wrote:

> When a timeout error occurs in i2c transter, it is usually related
> to the i2c/dma IP hardware configuration. Therefore, the purpose of
> this patch is to dump the key register values of i2c/dma when a
> timeout occurs in i2c for debugging.
> 
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: Qii Wang <qii.wang@mediatek.com>

I would like to test this patchset on one of supported platforms, an
mt6577-powered device. This driver requires a DMA base...
> 	i2c->pdmabase = devm_ioremap_resource(&pdev->dev, res);
>	if (IS_ERR(i2c->pdmabase))
>		return PTR_ERR(i2c->pdmabase);
... however I am not sure what address should I specify in the .dts file. While
other i2c busses supported by this driver such as mt6589 [1][2] and mt6797 [3]
have designated DMA for I2C, mt6577 seems to lack dedicated DMA engine for I2C
[4][5].

Do I need to specify the Generic DMA base address [4] instead?

Worth mentioning I brought up this issue in the past [5][6].

[1] ALPS.KK1.MP5.V1.3_EASTAEON89_WET_KK source code (downstream)
[2] MT6589 HSPA+ Smartphone Application Processor Datasheet v1.0, page 869
[3] MT6797 LTE-A Smartphone Application Processor Register Table (Part 1) v1.1,
page 1796
[4] MT6577 HSPA Smartphone Application Processor Datasheet v0.94, page 547
[5] ALPS.JB.MP.V1.19_MBK77_TB_JB source code (downstream)
[6] https://marc.info/?l=devicetree&m=159949247901831&w=2
[7] https://marc.info/?l=linux-i2c&m=159939730714187&w=2

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

             reply	other threads:[~2021-10-11 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 15:38 Boris Lysov [this message]
2021-10-11 15:38 ` [PATCH v8 2/5] i2c: mediatek: Dump i2c/dma register when a timeout occurs Boris Lysov
2021-10-25  6:09 ` Kewei Xu
2021-10-25  6:09   ` Kewei Xu
  -- strict thread matches above, loose matches on Subject: below --
2021-10-10  7:05 [PATCH v8 0/5] Introducing an attribute to select the time setting Kewei Xu
2021-10-10  7:05 ` [PATCH v8 2/5] i2c: mediatek: Dump i2c/dma register when a timeout occurs Kewei Xu
2021-10-10  7:05   ` Kewei Xu
2021-10-10  7:05   ` Kewei Xu
2021-10-11 10:41   ` Wolfram Sang
2021-10-11 10:41     ` Wolfram Sang
2021-10-11 10:41     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011183814.488ed866@pc \
    --to=arzamas-16@mail.ee \
    --cc=kewei.xu@mediatek.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=qii.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.