From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Zdenek Kabelac <zkabelac@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
Date: Tue, 12 Oct 2021 08:20:49 +0200 [thread overview]
Message-ID: <20211012062049.GB17407@lst.de> (raw)
In-Reply-To: <alpine.LRH.2.02.2110040851130.30719@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote:
> Do you want this patch?
Yes, this looks like what I want. Minor nitpicks below:
> + .fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED,
I'd probably call this fallocate_supported_flags.
> + .fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE,
Please avoid over 80 lines for a plain list of flags.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
Zdenek Kabelac <zkabelac@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
Date: Tue, 12 Oct 2021 08:20:49 +0200 [thread overview]
Message-ID: <20211012062049.GB17407@lst.de> (raw)
In-Reply-To: <alpine.LRH.2.02.2110040851130.30719@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote:
> Do you want this patch?
Yes, this looks like what I want. Minor nitpicks below:
> + .fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED,
I'd probably call this fallocate_supported_flags.
> + .fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE,
Please avoid over 80 lines for a plain list of flags.
next prev parent reply other threads:[~2021-10-12 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 19:48 [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard Mikulas Patocka
2021-09-24 0:17 ` Ming Lei
2021-09-24 15:58 ` Christoph Hellwig
2021-10-04 13:01 ` [dm-devel] " Mikulas Patocka
2021-10-04 13:01 ` Mikulas Patocka
2021-10-12 6:20 ` Christoph Hellwig [this message]
2021-10-12 6:20 ` Christoph Hellwig
2021-10-12 20:25 ` [dm-devel] [PATCH v3] " Mikulas Patocka
2021-10-12 20:25 ` Mikulas Patocka
2021-10-13 2:56 ` [dm-devel] " kernel test robot
2021-10-13 2:56 ` kernel test robot
2021-10-13 2:56 ` kernel test robot
2021-10-13 5:06 ` [dm-devel] " kernel test robot
2021-10-13 5:06 ` kernel test robot
2021-10-13 5:06 ` kernel test robot
2021-10-13 9:28 ` [dm-devel] [PATCH v4] " Mikulas Patocka
2021-10-13 9:28 ` Mikulas Patocka
2021-10-27 5:02 ` [dm-devel] " Dave Chinner
2021-10-27 5:02 ` Dave Chinner
2021-10-27 8:28 ` [dm-devel] " Mikulas Patocka
2021-10-27 8:28 ` Mikulas Patocka
2021-10-28 4:15 ` [dm-devel] " Dave Chinner
2021-10-28 4:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012062049.GB17407@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.