From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
Date: Wed, 13 Oct 2021 11:36:52 +0300 [thread overview]
Message-ID: <202110130654.0li2Ip34-lkp@intel.com> (raw)
In-Reply-To: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
Hi Krzysztof,
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/hwmon/tmp421.c:178 tmp421_enable_channels() error: uninitialized symbol 'err'.
vim +/err +178 drivers/hwmon/tmp421.c
4a0f8262fe071b Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 169 {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 170 int err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 174 int i;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 175
4a0f8262fe071b Krzysztof Adamski 2021-10-12 176 if (cfg < 0) {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 @178 return err;
"return cfg;"
4a0f8262fe071b Krzysztof Adamski 2021-10-12 179 }
4a0f8262fe071b Krzysztof Adamski 2021-10-12 180
4a0f8262fe071b Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 185
4a0f8262fe071b Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 187 if (err < 0)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 189
4a0f8262fe071b Krzysztof Adamski 2021-10-12 190 return err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 191 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
Date: Wed, 13 Oct 2021 06:41:21 +0800 [thread overview]
Message-ID: <202110130654.0li2Ip34-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3667 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
References: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
TO: Krzysztof Adamski <krzysztof.adamski@nokia.com>
TO: Guenter Roeck <linux@roeck-us.net>
TO: Jean Delvare <jdelvare@suse.com>
CC: Rob Herring <robh+dt@kernel.org>
CC: linux-hwmon(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
Hi Krzysztof,
I love your patch! Perhaps something to improve:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on next-20211012]
[cannot apply to robh/for-next v5.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/hwmon/tmp421.c:178 tmp421_enable_channels() error: uninitialized symbol 'err'.
vim +/err +178 drivers/hwmon/tmp421.c
9410700b881f86 Andre Prendel 2009-09-15 167
4a0f8262fe071b Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 169 {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 170 int err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 174 int i;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 175
4a0f8262fe071b Krzysztof Adamski 2021-10-12 176 if (cfg < 0) {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 @178 return err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 179 }
4a0f8262fe071b Krzysztof Adamski 2021-10-12 180
4a0f8262fe071b Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 185
4a0f8262fe071b Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 187 if (err < 0)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 189
4a0f8262fe071b Krzysztof Adamski 2021-10-12 190 return err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 191 }
4a0f8262fe071b Krzysztof Adamski 2021-10-12 192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34043 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
Date: Wed, 13 Oct 2021 11:36:52 +0300 [thread overview]
Message-ID: <202110130654.0li2Ip34-lkp@intel.com> (raw)
In-Reply-To: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 2658 bytes --]
Hi Krzysztof,
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/hwmon/tmp421.c:178 tmp421_enable_channels() error: uninitialized symbol 'err'.
vim +/err +178 drivers/hwmon/tmp421.c
4a0f8262fe071b Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 169 {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 170 int err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 174 int i;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 175
4a0f8262fe071b Krzysztof Adamski 2021-10-12 176 if (cfg < 0) {
4a0f8262fe071b Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 @178 return err;
"return cfg;"
4a0f8262fe071b Krzysztof Adamski 2021-10-12 179 }
4a0f8262fe071b Krzysztof Adamski 2021-10-12 180
4a0f8262fe071b Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 185
4a0f8262fe071b Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b Krzysztof Adamski 2021-10-12 187 if (err < 0)
4a0f8262fe071b Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 189
4a0f8262fe071b Krzysztof Adamski 2021-10-12 190 return err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12 191 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next parent reply other threads:[~2021-10-13 8:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 22:41 kernel test robot [this message]
2021-10-13 8:36 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels Dan Carpenter
2021-10-13 8:36 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-11-16 0:53 kernel test robot
2021-11-16 9:09 ` kernel test robot
2021-11-16 9:09 ` kernel test robot
2021-10-12 9:14 [PATCH v4 00/10] Add per channel properies support in tmp421 Krzysztof Adamski
2021-10-12 9:14 ` [PATCH v4 01/10] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-12 9:26 ` [PATCH v4 02/10] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-10-12 14:25 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 03/10] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-12 14:30 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 04/10] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-10-12 14:32 ` Guenter Roeck
2021-10-12 9:28 ` [PATCH v4 05/10] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-10-12 14:34 ` Guenter Roeck
2021-10-12 9:29 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-10-12 14:37 ` Guenter Roeck
2021-10-12 18:01 ` kernel test robot
2021-10-12 18:01 ` kernel test robot
2021-10-13 18:50 ` kernel test robot
2021-10-13 18:50 ` kernel test robot
2021-10-12 9:29 ` [PATCH v4 07/10] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 08/10] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 09/10] hwmon: (tmp421) ignore non-channel related DT nodes Krzysztof Adamski
2021-10-12 14:44 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 10/10] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110130654.0li2Ip34-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.