Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config

[Cristian Marussi <cristian.marussi@arm.com>]

On Fri, Oct 15, 2021 at 04:00:43PM +0100, Sudeep Holla wrote:
> Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
> introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
> used anywhere.
> 
> Further, it looks like this Kconfig option is just to select bunch of other
> options which doesn't sound correct to me. There is no need for another
> SCMI firmware based clock driver and hence the same applies for the config
> option too.
> 
> Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
> someone idea to write a specific clock driver for this SoC/platform.
> 
> Cc: Etienne Carriere <etienne.carriere@foss.st.com>
> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Looking at the original commit, and guessing its original aim,
is it not better to put some sort of WARN in the STM32MP157 driver
when the specific "rcc-secure" compatible is found configured BUT
!IS_ENABLED(COMMON_CLK_SCMI) ?

Thanks,
Cristian

>  drivers/clk/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c5b3dc97396a..b64058d1af2d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -339,16 +339,6 @@ config COMMON_CLK_STM32MP157
>  	help
>  	  Support for stm32mp157 SoC family clocks
>  
> -config COMMON_CLK_STM32MP157_SCMI
> -	bool "stm32mp157 Clock driver with Trusted Firmware"
> -	depends on COMMON_CLK_STM32MP157
> -	select COMMON_CLK_SCMI
> -	select ARM_SCMI_PROTOCOL
> -	default y
> -	help
> -	  Support for stm32mp157 SoC family clocks with Trusted Firmware using
> -	  SCMI protocol.
> -
>  config COMMON_CLK_STM32F
>  	def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
>  	help
> -- 
> 2.25.1
>