From: Keith Busch <kbusch@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, geoff@infradead.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org, jim@jtan.com,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, hch@lst.de,
sagi@grimberg.me, linux-block@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org,
nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] nvme-multipath: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 18:01:18 -0600 [thread overview]
Message-ID: <20211016000118.GA50317@C02WT3WMHTD6> (raw)
In-Reply-To: <20211015235219.2191207-3-mcgrof@kernel.org>
On Fri, Oct 15, 2021 at 04:52:08PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Since we now can tell for sure when a disk was added, move
> setting the bit NVME_NSHEAD_DISK_LIVE only when we did
> add the disk successfully.
>
> Nothing to do here as the cleanup is done elsewhere. We take
> care and use test_and_set_bit() because it is protects against
> two nvme paths simultaneously calling device_add_disk() on the
> same namespace head.
Looks good, thank you.
Reviewed-by: Keith Busch <kbusch@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, geoff@infradead.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org, jim@jtan.com,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, hch@lst.de,
sagi@grimberg.me, linux-block@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org,
nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] nvme-multipath: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 18:01:18 -0600 [thread overview]
Message-ID: <20211016000118.GA50317@C02WT3WMHTD6> (raw)
In-Reply-To: <20211015235219.2191207-3-mcgrof@kernel.org>
On Fri, Oct 15, 2021 at 04:52:08PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Since we now can tell for sure when a disk was added, move
> setting the bit NVME_NSHEAD_DISK_LIVE only when we did
> add the disk successfully.
>
> Nothing to do here as the cleanup is done elsewhere. We take
> care and use test_and_set_bit() because it is protects against
> two nvme paths simultaneously calling device_add_disk() on the
> same namespace head.
Looks good, thank you.
Reviewed-by: Keith Busch <kbusch@kernel.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: nvdimm@lists.linux.dev, vigneshr@ti.com,
linux-nvme@lists.infradead.org, paulus@samba.org,
miquel.raynal@bootlin.com, ira.weiny@intel.com, hch@lst.de,
dave.jiang@intel.com, sagi@grimberg.me, minchan@kernel.org,
vishal.l.verma@intel.com, ngupta@vflare.org,
linux-block@vger.kernel.org, dan.j.williams@intel.com,
axboe@kernel.dk, geoff@infradead.org,
linux-kernel@vger.kernel.org, jim@jtan.com,
senozhatsky@chromium.org, richard@nod.at,
linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/13] nvme-multipath: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 18:01:18 -0600 [thread overview]
Message-ID: <20211016000118.GA50317@C02WT3WMHTD6> (raw)
In-Reply-To: <20211015235219.2191207-3-mcgrof@kernel.org>
On Fri, Oct 15, 2021 at 04:52:08PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Since we now can tell for sure when a disk was added, move
> setting the bit NVME_NSHEAD_DISK_LIVE only when we did
> add the disk successfully.
>
> Nothing to do here as the cleanup is done elsewhere. We take
> care and use test_and_set_bit() because it is protects against
> two nvme paths simultaneously calling device_add_disk() on the
> same namespace head.
Looks good, thank you.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2021-10-16 0:01 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 23:52 [PATCH 00/13] block: add_disk() error handling stragglers Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 01/13] block/brd: add error handling support for add_disk() Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 02/13] nvme-multipath: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-16 0:01 ` Keith Busch [this message]
2021-10-16 0:01 ` Keith Busch
2021-10-16 0:01 ` Keith Busch
2021-10-16 4:39 ` Christoph Hellwig
2021-10-16 4:39 ` Christoph Hellwig
2021-10-16 4:39 ` Christoph Hellwig
2021-10-18 5:34 ` Chaitanya Kulkarni
2021-10-18 5:34 ` Chaitanya Kulkarni
2021-10-18 5:34 ` Chaitanya Kulkarni
2021-10-15 23:52 ` [PATCH 03/13] nvdimm/btt: do not call del_gendisk() if not needed Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-31 17:47 ` Dan Williams
2021-10-31 17:47 ` Dan Williams
2021-10-31 17:47 ` Dan Williams
2021-11-02 17:03 ` Luis Chamberlain
2021-11-02 17:03 ` Luis Chamberlain
2021-11-02 17:03 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 04/13] nvdimm/btt: use goto error labels on btt_blk_init() Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-31 17:51 ` Dan Williams
2021-10-31 17:51 ` Dan Williams
2021-10-31 17:51 ` Dan Williams
2021-10-15 23:52 ` [PATCH 05/13] nvdimm/btt: add error handling support for add_disk() Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 06/13] nvdimm/blk: avoid calling del_gendisk() on early failures Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-16 0:13 ` Dan Williams
2021-10-16 0:13 ` Dan Williams
2021-10-16 0:13 ` Dan Williams
2021-10-19 16:06 ` Luis Chamberlain
2021-10-19 16:06 ` Luis Chamberlain
2021-10-19 16:06 ` Luis Chamberlain
2021-11-03 0:10 ` Luis Chamberlain
2021-11-03 0:10 ` Luis Chamberlain
2021-11-03 0:10 ` Luis Chamberlain
2021-11-03 0:49 ` Dan Williams
2021-11-03 0:49 ` Dan Williams
2021-11-03 0:49 ` Dan Williams
2021-11-03 1:28 ` Jens Axboe
2021-11-03 1:28 ` Jens Axboe
2021-11-03 1:28 ` Jens Axboe
2021-11-03 12:09 ` Luis Chamberlain
2021-11-03 12:09 ` Luis Chamberlain
2021-11-03 12:09 ` Luis Chamberlain
2021-11-03 12:08 ` Luis Chamberlain
2021-11-03 12:08 ` Luis Chamberlain
2021-11-03 12:08 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 07/13] nvdimm/blk: add error handling support for add_disk() Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 08/13] zram: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-25 16:55 ` Minchan Kim
2021-10-25 16:55 ` Minchan Kim
2021-10-25 16:55 ` Minchan Kim
2021-10-15 23:52 ` [PATCH 09/13] z2ram: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 10/13] ps3disk: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-29 15:05 ` Geoff Levand
2021-10-29 15:05 ` Geoff Levand
2021-10-29 15:05 ` Geoff Levand
2021-10-15 23:52 ` [PATCH 11/13] ps3vram: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-29 15:09 ` Geoff Levand
2021-10-29 15:09 ` Geoff Levand
2021-10-29 15:09 ` Geoff Levand
2021-10-15 23:52 ` [PATCH 12/13] block/sunvdc: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` [PATCH 13/13] mtd/ubi/block: " Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-15 23:52 ` Luis Chamberlain
2021-10-17 15:26 ` [PATCH 00/13] block: add_disk() error handling stragglers Geoff Levand
2021-10-17 15:26 ` Geoff Levand
2021-10-17 15:26 ` Geoff Levand
2021-10-18 16:15 ` Luis Chamberlain
2021-10-18 16:15 ` Luis Chamberlain
2021-10-18 16:15 ` Luis Chamberlain
2021-10-22 3:10 ` Geoff Levand
2021-10-22 3:10 ` Geoff Levand
2021-10-22 3:10 ` Geoff Levand
2021-10-25 15:58 ` Luis Chamberlain
2021-10-25 15:58 ` Luis Chamberlain
2021-10-25 15:58 ` Luis Chamberlain
2021-10-30 17:03 ` (subset) " Jens Axboe
2021-10-30 17:03 ` Jens Axboe
2021-10-30 17:03 ` Jens Axboe
2021-10-30 17:07 ` Jens Axboe
2021-10-30 17:07 ` Jens Axboe
2021-10-30 17:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016000118.GA50317@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=geoff@infradead.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jim@jtan.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mpe@ellerman.id.au \
--cc=ngupta@vflare.org \
--cc=nvdimm@lists.linux.dev \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=sagi@grimberg.me \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.