Re: [PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3107 bytes --]

Hi Simon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on f6632721cd6231e1bf28b5317dcc7543e43359f7]

url:    https://github.com/0day-ci/linux/commits/Simon-Ser/drm-add-per-connector-hotplug-events/20211016-003611
base:   f6632721cd6231e1bf28b5317dcc7543e43359f7
config: x86_64-randconfig-a006-20211015 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a49f5386ce6b091da66ea7c3a1d9a588d53becf7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fb2b373f5b3b0f1e37e56270bf7aa0e6332f880d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Simon-Ser/drm-add-per-connector-hotplug-events/20211016-003611
        git checkout fb2b373f5b3b0f1e37e56270bf7aa0e6332f880d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dp.c:5267:2: error: implicit declaration of function 'drm_sysfs_connector_status_event' [-Werror,-Wimplicit-function-declaration]
           drm_sysfs_connector_status_event(connector,
           ^
   drivers/gpu/drm/i915/display/intel_dp.c:5267:2: note: did you mean 'drm_get_connector_status_name'?
   include/drm/drm_connector.h:1729:13: note: 'drm_get_connector_status_name' declared here
   const char *drm_get_connector_status_name(enum drm_connector_status status);
               ^
   1 error generated.


vim +/drm_sysfs_connector_status_event +5267 drivers/gpu/drm/i915/display/intel_dp.c

  5245	
  5246	static void intel_dp_modeset_retry_work_fn(struct work_struct *work)
  5247	{
  5248		struct intel_connector *intel_connector;
  5249		struct drm_connector *connector;
  5250	
  5251		intel_connector = container_of(work, typeof(*intel_connector),
  5252					       modeset_retry_work);
  5253		connector = &intel_connector->base;
  5254		DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id,
  5255			      connector->name);
  5256	
  5257		/* Grab the locks before changing connector property*/
  5258		mutex_lock(&connector->dev->mode_config.mutex);
  5259		/* Set connector link status to BAD and send a Uevent to notify
  5260		 * userspace to do a modeset.
  5261		 */
  5262		drm_connector_set_link_status_property(connector,
  5263						       DRM_MODE_LINK_STATUS_BAD);
  5264		mutex_unlock(&connector->dev->mode_config.mutex);
  5265		/* Send Hotplug uevent so userspace can reprobe */
  5266		drm_kms_helper_hotplug_event(connector->dev);
> 5267		drm_sysfs_connector_status_event(connector,
  5268						 connector->dev->mode_config.link_status_property);
  5269	}
  5270	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33784 bytes --]