Re: [PATCH v13 02/10] PCI: kirin: Add support for a PHY layer

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3492 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.15-rc6 next-20211018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20211018-150945
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-randconfig-r004-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d245f2e8597bfb52c34810a328d42b990e4af1a4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/203dfb8c88a9a2b502b9e1db644565559e028cf2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20211018-150945
        git checkout 203dfb8c88a9a2b502b9e1db644565559e028cf2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-kirin.c:561:13: warning: cast to smaller integer type 'enum pcie_kirin_phy_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]
           phy_type = (enum pcie_kirin_phy_type)of_id->data;
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +561 drivers/pci/controller/dwc/pcie-kirin.c

   540	
   541	static int kirin_pcie_probe(struct platform_device *pdev)
   542	{
   543		enum pcie_kirin_phy_type phy_type;
   544		const struct of_device_id *of_id;
   545		struct device *dev = &pdev->dev;
   546		struct kirin_pcie *kirin_pcie;
   547		struct dw_pcie *pci;
   548		int ret;
   549	
   550		if (!dev->of_node) {
   551			dev_err(dev, "NULL node\n");
   552			return -EINVAL;
   553		}
   554	
   555		of_id = of_match_device(kirin_pcie_match, dev);
   556		if (!of_id) {
   557			dev_err(dev, "OF data missing\n");
   558			return -EINVAL;
   559		}
   560	
 > 561		phy_type = (enum pcie_kirin_phy_type)of_id->data;
   562	
   563		kirin_pcie = devm_kzalloc(dev, sizeof(struct kirin_pcie), GFP_KERNEL);
   564		if (!kirin_pcie)
   565			return -ENOMEM;
   566	
   567		pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL);
   568		if (!pci)
   569			return -ENOMEM;
   570	
   571		pci->dev = dev;
   572		pci->ops = &kirin_dw_pcie_ops;
   573		pci->pp.ops = &kirin_pcie_host_ops;
   574		kirin_pcie->pci = pci;
   575		kirin_pcie->type = phy_type;
   576	
   577		ret = kirin_pcie_get_resource(kirin_pcie, pdev);
   578		if (ret)
   579			return ret;
   580	
   581		platform_set_drvdata(pdev, kirin_pcie);
   582	
   583		ret = kirin_pcie_power_on(pdev, kirin_pcie);
   584		if (ret)
   585			return ret;
   586	
   587		return dw_pcie_host_init(&pci->pp);
   588	}
   589	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 43417 bytes --]