All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mtd: mtdconcat: add suspend lock handling
Date: Wed, 20 Oct 2021 10:55:47 +0200	[thread overview]
Message-ID: <20211020105547.23ed9324@collabora.com> (raw)
In-Reply-To: <20211020084534.2472305-5-sean@geanix.com>

On Wed, 20 Oct 2021 10:45:34 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> Use MTD hooks to control suspend/resume of MTD devices.

Please explain in great details why this is needed.

> 
> Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

This patch should be moved earlier (before 'mtd: core: protect access to
MTD devices while in suspend') in the series.

> ---
>  drivers/mtd/mtdconcat.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
> index f685a581df48..1ec36890118f 100644
> --- a/drivers/mtd/mtdconcat.c
> +++ b/drivers/mtd/mtdconcat.c
> @@ -566,9 +566,11 @@ static int concat_suspend(struct mtd_info *mtd)
>  
>  	for (i = 0; i < concat->num_subdev; i++) {
>  		struct mtd_info *subdev = concat->subdev[i];
> -		if ((rc = mtd_suspend(subdev)) < 0)
> +		rc = subdev->_suspend ? subdev->_suspend(subdev) : 0;
> +		if (rc < 0)
>  			return rc;

Same here, you need a fat comment explaining why mtd_suspend() is not
used.

>  	}
> +
>  	return rc;
>  }
>  
> @@ -579,7 +581,8 @@ static void concat_resume(struct mtd_info *mtd)
>  
>  	for (i = 0; i < concat->num_subdev; i++) {
>  		struct mtd_info *subdev = concat->subdev[i];
> -		mtd_resume(subdev);
> +		if (subdev->_resume)
> +			subdev->_resume(subdev);

Ditto.

>  	}
>  }
>  


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mtd: mtdconcat: add suspend lock handling
Date: Wed, 20 Oct 2021 10:55:47 +0200	[thread overview]
Message-ID: <20211020105547.23ed9324@collabora.com> (raw)
In-Reply-To: <20211020084534.2472305-5-sean@geanix.com>

On Wed, 20 Oct 2021 10:45:34 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> Use MTD hooks to control suspend/resume of MTD devices.

Please explain in great details why this is needed.

> 
> Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

This patch should be moved earlier (before 'mtd: core: protect access to
MTD devices while in suspend') in the series.

> ---
>  drivers/mtd/mtdconcat.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
> index f685a581df48..1ec36890118f 100644
> --- a/drivers/mtd/mtdconcat.c
> +++ b/drivers/mtd/mtdconcat.c
> @@ -566,9 +566,11 @@ static int concat_suspend(struct mtd_info *mtd)
>  
>  	for (i = 0; i < concat->num_subdev; i++) {
>  		struct mtd_info *subdev = concat->subdev[i];
> -		if ((rc = mtd_suspend(subdev)) < 0)
> +		rc = subdev->_suspend ? subdev->_suspend(subdev) : 0;
> +		if (rc < 0)
>  			return rc;

Same here, you need a fat comment explaining why mtd_suspend() is not
used.

>  	}
> +
>  	return rc;
>  }
>  
> @@ -579,7 +581,8 @@ static void concat_resume(struct mtd_info *mtd)
>  
>  	for (i = 0; i < concat->num_subdev; i++) {
>  		struct mtd_info *subdev = concat->subdev[i];
> -		mtd_resume(subdev);
> +		if (subdev->_resume)
> +			subdev->_resume(subdev);

Ditto.

>  	}
>  }
>  


  reply	other threads:[~2021-10-20  8:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  8:45 [PATCH v2 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-10-20  8:45 ` Sean Nyekjaer
2021-10-20  8:45 ` [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
2021-10-20  8:45   ` Sean Nyekjaer
2021-10-20  8:53   ` Boris Brezillon
2021-10-20  8:53     ` Boris Brezillon
2021-10-20  9:01     ` Sean Nyekjaer
2021-10-20  9:01       ` Sean Nyekjaer
2021-10-20  9:03       ` Boris Brezillon
2021-10-20  9:03         ` Boris Brezillon
2021-10-20  9:12         ` Miquel Raynal
2021-10-20  9:12           ` Miquel Raynal
2021-10-20  8:45 ` [PATCH v2 2/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer
2021-10-20  8:45   ` Sean Nyekjaer
2021-10-20  9:13   ` Boris Brezillon
2021-10-20  9:13     ` Boris Brezillon
2021-10-20  8:45 ` [PATCH v2 3/4] mtd: rawnand: remove suspended check Sean Nyekjaer
2021-10-20  8:45   ` Sean Nyekjaer
2021-10-20  8:57   ` Boris Brezillon
2021-10-20  8:57     ` Boris Brezillon
2021-10-20  9:14     ` Sean Nyekjaer
2021-10-20  9:14       ` Sean Nyekjaer
2021-10-20  8:45 ` [PATCH v2 4/4] mtd: mtdconcat: add suspend lock handling Sean Nyekjaer
2021-10-20  8:45   ` Sean Nyekjaer
2021-10-20  8:55   ` Boris Brezillon [this message]
2021-10-20  8:55     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020105547.23ed9324@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sean@geanix.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.