All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Štěpán Němec" <snemec@redhat.com>
To: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0
Date: Wed, 20 Oct 2021 14:44:09 +0200	[thread overview]
Message-ID: <20211020124409.489875-1-snemec@redhat.com> (raw)

POSIX [1] does not specify the behavior of `exit' with arguments
outside the 0-255 range, but what generally (bash, dash, zsh, OpenBSD
ksh, busybox) seems to happen is the shell exiting with status & 255
[2], which results in zero exit for certain non-zero arguments.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#exit
[2] https://git.savannah.gnu.org/cgit/bash.git/tree/builtins/common.c#n579

Fixes: 0c6592420586 ("tests: fix return codes")
Signed-off-by: Štěpán Němec <snemec@redhat.com>
---
 tests/build/run-tests.sh | 2 +-
 tests/shell/run-tests.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/build/run-tests.sh b/tests/build/run-tests.sh
index 9ce93a8ed381..f78cc9019a30 100755
--- a/tests/build/run-tests.sh
+++ b/tests/build/run-tests.sh
@@ -52,4 +52,4 @@ done
 rm -rf $tmpdir
 
 echo "results: [OK] $ok [FAILED] $failed [TOTAL] $((ok+failed))"
-exit $failed
+[ "$failed" -eq 0 ]
diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index 349ec6cb1b16..f77d850ef285 100755
--- a/tests/shell/run-tests.sh
+++ b/tests/shell/run-tests.sh
@@ -160,4 +160,4 @@ echo ""
 msg_info "results: [OK] $ok [FAILED] $failed [TOTAL] $((ok+failed))"
 
 kernel_cleanup
-exit $failed
+[ "$failed" -eq 0 ]

base-commit: 2139913694a9850c9160920b2c638aac4828f9bb
-- 
2.33.1


             reply	other threads:[~2021-10-20 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:44 Štěpán Němec [this message]
2021-10-20 15:06 ` [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0 Phil Sutter
2021-10-27  9:09   ` Pablo Neira Ayuso
2021-11-02 20:31     ` Phil Sutter
2021-11-02 20:44       ` Pablo Neira Ayuso
2021-11-02 21:01         ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020124409.489875-1-snemec@redhat.com \
    --to=snemec@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.