All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Phil Sutter" <phil@nwl.cc>, "Štěpán Němec" <snemec@redhat.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0
Date: Wed, 27 Oct 2021 11:09:23 +0200	[thread overview]
Message-ID: <YXkXQ2hrbZJ7YLcw@salvia> (raw)
In-Reply-To: <20211020150641.GK1668@orbyte.nwl.cc>

Hi Phil,

On Wed, Oct 20, 2021 at 05:06:41PM +0200, Phil Sutter wrote:
> Hi,
> 
> On Wed, Oct 20, 2021 at 02:44:09PM +0200, Štěpán Němec wrote:
> > POSIX [1] does not specify the behavior of `exit' with arguments
> > outside the 0-255 range, but what generally (bash, dash, zsh, OpenBSD
> > ksh, busybox) seems to happen is the shell exiting with status & 255
> > [2], which results in zero exit for certain non-zero arguments.
> 
> Standards aside, failed=256 is an actual bug:
> 
> | % bash -c "exit 255"; echo $?
> | 255
> | % bash -c "exit 256"; echo $?
> | 0
> | % bash -c "exit 257"; echo $?
> | 1

This is extra information you provided here for the commit message for
completion?

Thanks.

  reply	other threads:[~2021-10-27  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:44 [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0 Štěpán Němec
2021-10-20 15:06 ` Phil Sutter
2021-10-27  9:09   ` Pablo Neira Ayuso [this message]
2021-11-02 20:31     ` Phil Sutter
2021-11-02 20:44       ` Pablo Neira Ayuso
2021-11-02 21:01         ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXkXQ2hrbZJ7YLcw@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=snemec@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.