* [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation
@ 2021-10-20 12:03 Grzegorz Blach
2021-10-20 16:30 ` Peter Seiderer
2021-10-20 16:39 ` Yann E. MORIN
0 siblings, 2 replies; 3+ messages in thread
From: Grzegorz Blach @ 2021-10-20 12:03 UTC (permalink / raw)
To: buildroot; +Cc: Grzegorz Blach, Martin Bark, Mahyar Koshkouei
Variable PACKAGE_RPI_FIRMWARE_CONFIG_FILE is always undefined,
so RPI_FIRMWARE_CONFIG_FILE should be used instead.
Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
---
package/rpi-firmware/rpi-firmware.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 8a6a435f63..0929d6af1e 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -28,9 +28,9 @@ define RPI_FIRMWARE_INSTALL_BIN
endef
RPI_FIRMWARE_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE))
-ifneq ($(PACKAGE_RPI_FIRMWARE_CONFIG_FILE),)
+ifneq ($(RPI_FIRMWARE_CONFIG_FILE),)
define RPI_FIRMWARE_INSTALL_CONFIG
- $(INSTALL) -D -m 0644 $(PACKAGE_RPI_FIRMWARE_CONFIG_FILE) \
+ $(INSTALL) -D -m 0644 $(RPI_FIRMWARE_CONFIG_FILE) \
$(BINARIES_DIR)/rpi-firmware/config.txt
endef
endif
--
2.27.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation
2021-10-20 12:03 [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation Grzegorz Blach
@ 2021-10-20 16:30 ` Peter Seiderer
2021-10-20 16:39 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2021-10-20 16:30 UTC (permalink / raw)
To: Grzegorz Blach; +Cc: Yann E. MORIN, Martin Bark, Mahyar Koshkouei, buildroot
Hello Grzegorz,
On Wed, 20 Oct 2021 14:03:24 +0200, Grzegorz Blach <grzegorz@blach.pl> wrote:
> Variable PACKAGE_RPI_FIRMWARE_CONFIG_FILE is always undefined,
> so RPI_FIRMWARE_CONFIG_FILE should be used instead.
>
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> ---
> package/rpi-firmware/rpi-firmware.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 8a6a435f63..0929d6af1e 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -28,9 +28,9 @@ define RPI_FIRMWARE_INSTALL_BIN
> endef
>
> RPI_FIRMWARE_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE))
> -ifneq ($(PACKAGE_RPI_FIRMWARE_CONFIG_FILE),)
> +ifneq ($(RPI_FIRMWARE_CONFIG_FILE),)
> define RPI_FIRMWARE_INSTALL_CONFIG
> - $(INSTALL) -D -m 0644 $(PACKAGE_RPI_FIRMWARE_CONFIG_FILE) \
> + $(INSTALL) -D -m 0644 $(RPI_FIRMWARE_CONFIG_FILE) \
> $(BINARIES_DIR)/rpi-firmware/config.txt
> endef
> endif
Thanks for spotting (and fixing) this...
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation
2021-10-20 12:03 [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation Grzegorz Blach
2021-10-20 16:30 ` Peter Seiderer
@ 2021-10-20 16:39 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-10-20 16:39 UTC (permalink / raw)
To: Grzegorz Blach; +Cc: Martin Bark, Mahyar Koshkouei, buildroot
Grzegorz, All,
On 2021-10-20 14:03 +0200, Grzegorz Blach spake thusly:
> Variable PACKAGE_RPI_FIRMWARE_CONFIG_FILE is always undefined,
> so RPI_FIRMWARE_CONFIG_FILE should be used instead.
>
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
Applied to master, after rewriting the commit log to blame myself with
the last-minute change. Thanks!
Regards,
Yann E. MORIN.
> ---
> package/rpi-firmware/rpi-firmware.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 8a6a435f63..0929d6af1e 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -28,9 +28,9 @@ define RPI_FIRMWARE_INSTALL_BIN
> endef
>
> RPI_FIRMWARE_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE))
> -ifneq ($(PACKAGE_RPI_FIRMWARE_CONFIG_FILE),)
> +ifneq ($(RPI_FIRMWARE_CONFIG_FILE),)
> define RPI_FIRMWARE_INSTALL_CONFIG
> - $(INSTALL) -D -m 0644 $(PACKAGE_RPI_FIRMWARE_CONFIG_FILE) \
> + $(INSTALL) -D -m 0644 $(RPI_FIRMWARE_CONFIG_FILE) \
> $(BINARIES_DIR)/rpi-firmware/config.txt
> endef
> endif
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-20 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 12:03 [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation Grzegorz Blach
2021-10-20 16:30 ` Peter Seiderer
2021-10-20 16:39 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.