From: kernel test robot <lkp@intel.com>
To: Stephen Boyd <swboyd@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v3 03/34] component: Introduce the aggregate bus_type
Date: Tue, 26 Oct 2021 12:40:44 +0800 [thread overview]
Message-ID: <202110261214.TMBEmJIO-lkp@intel.com> (raw)
In-Reply-To: <20211026000044.885195-4-swboyd@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 4038 bytes --]
Hi Stephen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on e4e737bb5c170df6135a127739a9e6148ee3da82]
url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/component-Make-into-an-aggregate-bus/20211026-080422
base: e4e737bb5c170df6135a127739a9e6148ee3da82
config: ia64-defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/748369f5c5e62a44653d9b76cdbdadc835dd54d2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephen-Boyd/component-Make-into-an-aggregate-bus/20211026-080422
git checkout 748369f5c5e62a44653d9b76cdbdadc835dd54d2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/base/component.c: In function '__component_add':
>> drivers/base/component.c:858:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
858 | int ret;
| ^~~
vim +/ret +858 drivers/base/component.c
2a41e6070dd7ef Russell King 2014-01-10 853
3521ee994bca90 Daniel Vetter 2019-02-08 854 static int __component_add(struct device *dev, const struct component_ops *ops,
3521ee994bca90 Daniel Vetter 2019-02-08 855 int subcomponent)
2a41e6070dd7ef Russell King 2014-01-10 856 {
2a41e6070dd7ef Russell King 2014-01-10 857 struct component *component;
2a41e6070dd7ef Russell King 2014-01-10 @858 int ret;
2a41e6070dd7ef Russell King 2014-01-10 859
2a41e6070dd7ef Russell King 2014-01-10 860 component = kzalloc(sizeof(*component), GFP_KERNEL);
2a41e6070dd7ef Russell King 2014-01-10 861 if (!component)
2a41e6070dd7ef Russell King 2014-01-10 862 return -ENOMEM;
2a41e6070dd7ef Russell King 2014-01-10 863
2a41e6070dd7ef Russell King 2014-01-10 864 component->ops = ops;
2a41e6070dd7ef Russell King 2014-01-10 865 component->dev = dev;
3521ee994bca90 Daniel Vetter 2019-02-08 866 component->subcomponent = subcomponent;
2a41e6070dd7ef Russell King 2014-01-10 867
2a41e6070dd7ef Russell King 2014-01-10 868 dev_dbg(dev, "adding component (ops %ps)\n", ops);
2a41e6070dd7ef Russell King 2014-01-10 869
2a41e6070dd7ef Russell King 2014-01-10 870 mutex_lock(&component_mutex);
2a41e6070dd7ef Russell King 2014-01-10 871 list_add_tail(&component->node, &component_list);
2a41e6070dd7ef Russell King 2014-01-10 872 mutex_unlock(&component_mutex);
2a41e6070dd7ef Russell King 2014-01-10 873
748369f5c5e62a Stephen Boyd 2021-10-25 874 /*
748369f5c5e62a Stephen Boyd 2021-10-25 875 * Try to bind.
748369f5c5e62a Stephen Boyd 2021-10-25 876 *
748369f5c5e62a Stephen Boyd 2021-10-25 877 * Note: we don't check the return value here because component devices
748369f5c5e62a Stephen Boyd 2021-10-25 878 * don't care that the aggregate device can actually probe or not. They
748369f5c5e62a Stephen Boyd 2021-10-25 879 * only care about adding themselves to the component_list and then
748369f5c5e62a Stephen Boyd 2021-10-25 880 * waiting for their component_ops::bind_component callback to be
748369f5c5e62a Stephen Boyd 2021-10-25 881 * called.
748369f5c5e62a Stephen Boyd 2021-10-25 882 */
748369f5c5e62a Stephen Boyd 2021-10-25 883 ret = bus_rescan_devices(&aggregate_bus_type);
748369f5c5e62a Stephen Boyd 2021-10-25 884
748369f5c5e62a Stephen Boyd 2021-10-25 885 return 0;
2a41e6070dd7ef Russell King 2014-01-10 886 }
3521ee994bca90 Daniel Vetter 2019-02-08 887
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19985 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 03/34] component: Introduce the aggregate bus_type
Date: Tue, 26 Oct 2021 12:40:44 +0800 [thread overview]
Message-ID: <202110261214.TMBEmJIO-lkp@intel.com> (raw)
In-Reply-To: <20211026000044.885195-4-swboyd@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 4112 bytes --]
Hi Stephen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on e4e737bb5c170df6135a127739a9e6148ee3da82]
url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/component-Make-into-an-aggregate-bus/20211026-080422
base: e4e737bb5c170df6135a127739a9e6148ee3da82
config: ia64-defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/748369f5c5e62a44653d9b76cdbdadc835dd54d2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephen-Boyd/component-Make-into-an-aggregate-bus/20211026-080422
git checkout 748369f5c5e62a44653d9b76cdbdadc835dd54d2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/base/component.c: In function '__component_add':
>> drivers/base/component.c:858:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
858 | int ret;
| ^~~
vim +/ret +858 drivers/base/component.c
2a41e6070dd7ef Russell King 2014-01-10 853
3521ee994bca90 Daniel Vetter 2019-02-08 854 static int __component_add(struct device *dev, const struct component_ops *ops,
3521ee994bca90 Daniel Vetter 2019-02-08 855 int subcomponent)
2a41e6070dd7ef Russell King 2014-01-10 856 {
2a41e6070dd7ef Russell King 2014-01-10 857 struct component *component;
2a41e6070dd7ef Russell King 2014-01-10 @858 int ret;
2a41e6070dd7ef Russell King 2014-01-10 859
2a41e6070dd7ef Russell King 2014-01-10 860 component = kzalloc(sizeof(*component), GFP_KERNEL);
2a41e6070dd7ef Russell King 2014-01-10 861 if (!component)
2a41e6070dd7ef Russell King 2014-01-10 862 return -ENOMEM;
2a41e6070dd7ef Russell King 2014-01-10 863
2a41e6070dd7ef Russell King 2014-01-10 864 component->ops = ops;
2a41e6070dd7ef Russell King 2014-01-10 865 component->dev = dev;
3521ee994bca90 Daniel Vetter 2019-02-08 866 component->subcomponent = subcomponent;
2a41e6070dd7ef Russell King 2014-01-10 867
2a41e6070dd7ef Russell King 2014-01-10 868 dev_dbg(dev, "adding component (ops %ps)\n", ops);
2a41e6070dd7ef Russell King 2014-01-10 869
2a41e6070dd7ef Russell King 2014-01-10 870 mutex_lock(&component_mutex);
2a41e6070dd7ef Russell King 2014-01-10 871 list_add_tail(&component->node, &component_list);
2a41e6070dd7ef Russell King 2014-01-10 872 mutex_unlock(&component_mutex);
2a41e6070dd7ef Russell King 2014-01-10 873
748369f5c5e62a Stephen Boyd 2021-10-25 874 /*
748369f5c5e62a Stephen Boyd 2021-10-25 875 * Try to bind.
748369f5c5e62a Stephen Boyd 2021-10-25 876 *
748369f5c5e62a Stephen Boyd 2021-10-25 877 * Note: we don't check the return value here because component devices
748369f5c5e62a Stephen Boyd 2021-10-25 878 * don't care that the aggregate device can actually probe or not. They
748369f5c5e62a Stephen Boyd 2021-10-25 879 * only care about adding themselves to the component_list and then
748369f5c5e62a Stephen Boyd 2021-10-25 880 * waiting for their component_ops::bind_component callback to be
748369f5c5e62a Stephen Boyd 2021-10-25 881 * called.
748369f5c5e62a Stephen Boyd 2021-10-25 882 */
748369f5c5e62a Stephen Boyd 2021-10-25 883 ret = bus_rescan_devices(&aggregate_bus_type);
748369f5c5e62a Stephen Boyd 2021-10-25 884
748369f5c5e62a Stephen Boyd 2021-10-25 885 return 0;
2a41e6070dd7ef Russell King 2014-01-10 886 }
3521ee994bca90 Daniel Vetter 2019-02-08 887
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19985 bytes --]
next prev parent reply other threads:[~2021-10-26 4:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 0:00 [PATCH v3 00/34] component: Make into an aggregate bus Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 01/34] component: Introduce struct aggregate_device Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 02/34] component: Remove most references to 'master' Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 03/34] component: Introduce the aggregate bus_type Stephen Boyd
2021-10-26 4:40 ` kernel test robot [this message]
2021-10-26 4:40 ` kernel test robot
2021-10-26 14:02 ` kernel test robot
2021-10-26 14:02 ` kernel test robot
2021-10-26 19:33 ` Stephen Boyd
2021-10-26 19:33 ` Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 04/34] component: Move struct aggregate_device out to header file Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 05/34] component: Add {bind,unbind}_component() ops that take aggregate device Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 05/34] component: Add {bind, unbind}_component() " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 06/34] drm/of: Add a drm_of_aggregate_probe() API Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 07/34] drm/msm: Migrate to aggregate driver Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 08/34] drm/komeda: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 09/34] drm/arm/hdlcd: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 10/34] drm/malidp: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 11/34] drm/armada: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 12/34] drm/etnaviv: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 13/34] drm/kirin: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 14/34] drm/exynos: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 15/34] drm/imx: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 16/34] drm/ingenic: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 17/34] drm/mcde: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 18/34] drm/mediatek: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 19/34] drm/meson: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 20/34] drm/omap: " Stephen Boyd
2021-10-26 23:52 ` kernel test robot
2021-10-26 23:52 ` kernel test robot
2021-10-26 0:00 ` [PATCH v3 21/34] drm/rockchip: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 22/34] drm/sti: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 23/34] drm/sun4i: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 24/34] drm/tilcdc: " Stephen Boyd
2021-11-01 19:35 ` Jyri Sarha
2021-11-01 19:35 ` Jyri Sarha
2021-10-26 0:00 ` [PATCH v3 25/34] drm/vc4: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 26/34] drm/zte: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 27/34] iommu/mtk: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 28/34] mei: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 29/34] power: supply: ab8500: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 30/34] fbdev: omap2: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 31/34] sound: hdac: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 32/34] ASoC: codecs: wcd938x: " Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 33/34] component: Get rid of drm_of_component_probe() Stephen Boyd
2021-10-26 0:00 ` [PATCH v3 34/34] component: Remove component_master_ops and friends Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110261214.TMBEmJIO-lkp@intel.com \
--to=lkp@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.