Re: [PATCH mptcp-net] mptcp: fix corrupt receiver key in MPC + data + checksum

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2922 bytes --]

Hi Davide,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mptcp/export]
[also build test WARNING on linus/master v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325
base:   https://github.com/multipath-tcp/mptcp_net-next.git export
config: x86_64-randconfig-s022-20211025 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325
        git checkout 2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> net/mptcp/options.c:1240:14: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __sum16 [usertype] csum @@     got restricted __wsum @@
   net/mptcp/options.c:1240:14: sparse:     expected restricted __sum16 [usertype] csum
   net/mptcp/options.c:1240:14: sparse:     got restricted __wsum
>> net/mptcp/options.c:1241:39: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected restricted __wsum [usertype] sum @@     got restricted __sum16 [usertype] csum @@
   net/mptcp/options.c:1241:39: sparse:     expected restricted __wsum [usertype] sum
   net/mptcp/options.c:1241:39: sparse:     got restricted __sum16 [usertype] csum

vim +1240 net/mptcp/options.c

  1225	
  1226	static u16 __mptcp_make_csum(u64 data_seq, u32 subflow_seq, u16 data_len, __sum16 csum)
  1227	{
  1228		struct csum_pseudo_header header;
  1229	
  1230		/* cfr RFC 8684 3.3.1.:
  1231		 * the data sequence number used in the pseudo-header is
  1232		 * always the 64-bit value, irrespective of what length is used in the
  1233		 * DSS option itself.
  1234		 */
  1235		header.data_seq = cpu_to_be64(data_seq);
  1236		header.subflow_seq = htonl(subflow_seq);
  1237		header.data_len = htons(data_len);
  1238		header.csum = 0;
  1239	
> 1240		csum = csum_partial(&header, sizeof(header), ~csum_unfold(csum));
> 1241		return (__force u16)csum_fold(csum);
  1242	}
  1243	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40989 bytes --]