Re: [dm-devel] [PATCH 5/6] dax, pmem: Add data recovery feature to pmem_copy_to/from_iter()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4577 bytes --]

Hi Jane,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on device-mapper-dm/for-next]
[also build test WARNING on mszeredi-fuse/for-next linus/master v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jane-Chu/dax-poison-recovery-with-RWF_RECOVERY_DATA-flag/20211021-081336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: i386-randconfig-a013-20211022 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5dc339d9825f1dbe788cfb69c88210a59bbf8e3a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a01994a484c54b2f4b6eb32104ab3caf7b9b32a8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jane-Chu/dax-poison-recovery-with-RWF_RECOVERY_DATA-flag/20211021-081336
        git checkout a01994a484c54b2f4b6eb32104ab3caf7b9b32a8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/nvdimm/pmem.c:337:12: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
                                           addr, bytes);
                                                 ^~~~~
   include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn'
           dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                                                       ~~~     ^~~~~~~~~~~
   include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
                   _p_func(dev, fmt, ##__VA_ARGS__);                       \
                                ~~~    ^~~~~~~~~~~
   1 warning generated.


vim +337 drivers/nvdimm/pmem.c

   306	
   307	/*
   308	 * Even though the 'no check' versions of copy_from_iter_flushcache()
   309	 * and copy_mc_to_iter() are used to bypass HARDENED_USERCOPY overhead,
   310	 * 'read'/'write' aren't always safe when poison is consumed. They happen
   311	 * to be safe because the 'read'/'write' range has been guaranteed
   312	 * be free of poison(s) by a prior call to dax_direct_access() on the
   313	 * caller stack.
   314	 * However with the introduction of DAXDEV_F_RECOVERY, the 'read'/'write'
   315	 * range may contain poison(s), so the functions perform explicit check
   316	 * on poison, and 'read' end up fetching only non-poisoned page(s) up
   317	 * till  the first poison is encountered while 'write' require the range
   318	 * is page aligned in order to restore the poisoned page's memory type
   319	 * back to "rw" after clearing the poison(s).
   320	 * In the event of poison related failure, (size_t) -EIO is returned and
   321	 * caller may check the return value after casting it to (ssize_t).
   322	 */
   323	static size_t pmem_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff,
   324		void *addr, size_t bytes, struct iov_iter *i, unsigned long flags)
   325	{
   326		phys_addr_t pmem_off;
   327		size_t len, lead_off;
   328		struct pmem_device *pmem = dax_get_private(dax_dev);
   329		struct device *dev = pmem->bb.dev;
   330	
   331		if (flags & DAXDEV_F_RECOVERY) {
   332			lead_off = (unsigned long)addr & ~PAGE_MASK;
   333			len = PFN_PHYS(PFN_UP(lead_off + bytes));
   334			if (is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512, len)) {
   335				if (lead_off || !(PAGE_ALIGNED(bytes))) {
   336					dev_warn(dev, "Found poison, but addr(%p) and/or bytes(%#lx) not page aligned\n",
 > 337						addr, bytes);
   338					return (size_t) -EIO;
   339				}
   340				pmem_off = PFN_PHYS(pgoff) + pmem->data_offset;
   341				if (pmem_clear_poison(pmem, pmem_off, bytes) !=
   342						BLK_STS_OK)
   343					return (size_t) -EIO;
   344			}
   345		}
   346	
   347		return _copy_from_iter_flushcache(addr, bytes, i);
   348	}
   349	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41075 bytes --]

[-- Attachment #3: Type: text/plain, Size: 97 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel